[GitHub] [incubator-eventmesh] jinrongluo commented on a change in pull request #593: [Issue #417] gRPC design doc and protobuf models

[GitBox <gi...@apache.org>]

jinrongluo commented on a change in pull request #593:
URL: https://github.com/apache/incubator-eventmesh/pull/593#discussion_r750505488



##########
File path: settings.gradle
##########
@@ -37,4 +37,5 @@ include 'eventmesh-protocol-plugin'
 include 'eventmesh-protocol-plugin:eventmesh-protocol-api'
 include 'eventmesh-protocol-plugin:eventmesh-protocol-openmessage'
 include 'eventmesh-protocol-plugin:eventmesh-protocol-cloudevents'
+include 'eventmesh-protocol-plugin:eventmesh-protocol-grpc'

Review comment:
       this module only contains grpc protobuf and the generated java codes. the actual implementation will be in runtime module and SDK module.
   
   For now grpc is in experimental development. Once it is mature and in good shape, it can replace TCP/HTTP transport in the runtime module, and SDK side. Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org