[GitHub] [spark] juliuszsompolski commented on a diff in pull request #42441: [SPARK-44806][CONNECT] Separate `connect-client-jvm-internal` module to be able to test real in-process server with a real RPC client

["juliuszsompolski (via GitHub)" <gi...@apache.org>]

juliuszsompolski commented on code in PR #42441:
URL: https://github.com/apache/spark/pull/42441#discussion_r1293802942


##########
connector/connect/client/jvm-internal/src/test/scala/org/apache/spark/sql/connect/client/SparkConnectClientSuite.scala:
##########
@@ -0,0 +1,218 @@
+/*

Review Comment:
   This file has been mostly moved, but
   * DummySparkConnectService was moved to it's own util file
   * two tests were moved to SparkSessionDummyIntegrationSuite
   
   and it makes github see it as a full diff.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org