You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/04/15 05:52:13 UTC

[GitHub] [orc] williamhyun opened a new pull request #684: MINOR: Add William Hyun to committers.md

williamhyun opened a new pull request #684:
URL: https://github.com/apache/orc/pull/684


   ### What changes were proposed in this pull request?
   This PR aims to add `William Hyun` to the committers.md file. 
   
   
   ### Why are the changes needed?
   N/A
   
   
   ### How was this patch tested?
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on a change in pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #684:
URL: https://github.com/apache/orc/pull/684#discussion_r614495539



##########
File path: site/develop/committers.md
##########
@@ -46,6 +46,7 @@ Sergio Pena             | spena        | Committer
 Siddharth Seth          | sseth        | Committer
 Stephen Walkauskas      | swalkaus     | Committer
 Vaibhav Gumashta        | vgumashta    | Committer
+William Hyun            | william      | Committer

Review comment:
       It seems to be mixed.
   **ID-order**
   ```
   Gang Wu                 | gangwu       | PMC
   Alan Gates              | gates        | PMC
   ```
   
   **Name order(?)**
   ```
   Deepak Majeti           | mdeepak      | PMC
   Eugene Koifman          | ekoifman     | PMC
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] williamhyun commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-821769365


   I switched the lines to match the ID-alphabetical order.
   ```
   - William Hyun            | william      | Committer
     Wei Zheng               | weiz         | Committer
   + William Hyun            | william      | Committer
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-821890149


   Congratulations for your first merging, @williamhyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on a change in pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #684:
URL: https://github.com/apache/orc/pull/684#discussion_r614494683



##########
File path: site/develop/committers.md
##########
@@ -46,6 +46,7 @@ Sergio Pena             | spena        | Committer
 Siddharth Seth          | sseth        | Committer
 Stephen Walkauskas      | swalkaus     | Committer
 Vaibhav Gumashta        | vgumashta    | Committer
+William Hyun            | william      | Committer

Review comment:
       The order is alphabetical in ID, isn't it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-820862231


   Oh.. Got it. 
   
   Hi, @omalley . It seems that we need the power of PMC Chair. Could you give the committer permission to @williamhyun ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] williamhyun commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-821743236


   Hello @omalley , I already updated id.apache.org with my GitHub id. 
   <img width="735" alt="Screen Shot 2021-04-16 at 6 16 07 PM" src="https://user-images.githubusercontent.com/62487364/115097597-f75e9a80-9edf-11eb-8a71-ef618350ab72.png">
   
   But I cannot see the merge button. 
   <img width="419" alt="Screen Shot 2021-04-16 at 6 18 05 PM" src="https://user-images.githubusercontent.com/62487364/115097614-18bf8680-9ee0-11eb-95b8-92f704dbfdfb.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] asfgit merged pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #684:
URL: https://github.com/apache/orc/pull/684


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] williamhyun commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-820857656


   It seems that I don't have the committer permission yet. I cannot see `merge` button in GitHub and I cannot push via CLI.
   ```
   william@Williams-MacBook-Pro orc % git push apache HEAD:master
   ERROR: Permission to apache/orc.git denied to williamhyun.
   fatal: Could not read from remote repository.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on a change in pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #684:
URL: https://github.com/apache/orc/pull/684#discussion_r614496299



##########
File path: site/develop/committers.md
##########
@@ -46,6 +46,7 @@ Sergio Pena             | spena        | Committer
 Siddharth Seth          | sseth        | Committer
 Stephen Walkauskas      | swalkaus     | Committer
 Vaibhav Gumashta        | vgumashta    | Committer
+William Hyun            | william      | Committer

Review comment:
       ID-order looks dominant. We had better fix the sorting in a separate PR, @williamhyun and @pgaref .
   ```
   Matthew McCline         | mmccline     | Committer
   Sandeep More            | moresandeep  | Committer
   Naveen Gangam           | ngangam      | Committer
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] williamhyun commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-820852146


   @pgaref @dongjoon-hyun Thank you for your review,
   I thought the order was in alphabetical order with the IDs. 
   I will merge this and create a separate PR addressing this issue. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] williamhyun commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-821873007


   I will try gitbox.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] pgaref commented on a change in pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #684:
URL: https://github.com/apache/orc/pull/684#discussion_r613884982



##########
File path: site/develop/committers.md
##########
@@ -46,6 +46,7 @@ Sergio Pena             | spena        | Committer
 Siddharth Seth          | sseth        | Committer
 Stephen Walkauskas      | swalkaus     | Committer
 Vaibhav Gumashta        | vgumashta    | Committer
+William Hyun            | william      | Committer

Review comment:
       Order is alphabetical so it should probably be after Wei but feel free to merge after that




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] williamhyun commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-821873586


   It seems that gitbox works! Thank you all for your assistance. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] omalley commented on pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
omalley commented on pull request #684:
URL: https://github.com/apache/orc/pull/684#issuecomment-821339243


   William is already listed as an ORC committer: https://people.apache.org/phonebook.html?unix=orc
   He probably needs to update https://id.apache.org/ with his github id.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [orc] dongjoon-hyun commented on a change in pull request #684: MINOR: Add William Hyun to committers.md

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #684:
URL: https://github.com/apache/orc/pull/684#discussion_r614495539



##########
File path: site/develop/committers.md
##########
@@ -46,6 +46,7 @@ Sergio Pena             | spena        | Committer
 Siddharth Seth          | sseth        | Committer
 Stephen Walkauskas      | swalkaus     | Committer
 Vaibhav Gumashta        | vgumashta    | Committer
+William Hyun            | william      | Committer

Review comment:
       It seems that ID-order.
   ```
   Gang Wu                 | gangwu       | PMC
   Alan Gates              | gates        | PMC
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org