You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ws.apache.org by "Andreas Veithen (JIRA)" <ji...@apache.org> on 2016/02/21 21:35:18 UTC
[jira] [Resolved] (AXIOM-445) Ambiguously typed field & methods
associated with OMText
[ https://issues.apache.org/jira/browse/AXIOM-445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Veithen resolved AXIOM-445.
-----------------------------------
Resolution: Fixed
Assignee: Andreas Veithen
Fix Version/s: 1.3.0
> Ambiguously typed field & methods associated with OMText
> --------------------------------------------------------
>
> Key: AXIOM-445
> URL: https://issues.apache.org/jira/browse/AXIOM-445
> Project: Axiom
> Issue Type: Improvement
> Components: API
> Reporter: James Grahn
> Assignee: Andreas Veithen
> Priority: Minor
> Fix For: 1.3.0
>
>
> OMText has an ambiguously typed field "datahandler", which leads to ambiguously typed getters, setters, constructors, and factory methods (elsewhere).
> OMTextImpl's behavior (as of 1.2.10) requires that the "Object" argument be either a DataHandler or DataHandlerProvider. Any other object type will potentially result in a class cast exception within this class's own use. Moreover, this requirement is undocumented in the API Javadocs.
> Using properly typed field/constructor/getter/setter/factory methods would not only increase clarity to users and remove a potential ClassCastException, but also remove switch statements based upon instanceof.
> The field does have a comment which states the intent is "removing the dependency on javax.activation.DataHandler", but to what end? The import statement is included in the most recent versions of the OMTextImpl and there's a good chance the class would have to be present at runtime anyway. Furthermore, other classes within Axiom do require DataHandler as part of their interface.
> As this would be a change to the API, I assume any action on this would probably require waiting until a major version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ws.apache.org
For additional commands, e-mail: dev-help@ws.apache.org