[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3161: [CALCITE-5657] Add ARRAY_DISTINCT function (enabled in Spark library).

["JiajunBernoulli (via GitHub)" <gi...@apache.org>]

JiajunBernoulli commented on code in PR #3161:
URL: https://github.com/apache/calcite/pull/3161#discussion_r1174256987


##########
site/_docs/reference.md:
##########
@@ -2647,6 +2647,7 @@ BigQuery's type system uses confusingly different names for types and functions:
 | m | expr1 <=> expr2                                | Whether two values are equal, treating null values as the same, and it's similar to `IS NOT DISTINCT FROM`
 | b | ARRAY_CONCAT(array [, array ]*)                | Concatenates one or more arrays. If any input argument is `NULL` the function returns `NULL`
 | b | ARRAY_LENGTH(array)                            | Synonym for `CARDINALITY`
+| s | ARRAY_DISTINCT(array)                          | Returns unique elements of *array*. Keeps ordering of elements.

Review Comment:
   Should ARRAY_DISTINCT between ARRAY_CONCAT and ARRAY_LENGTH?
   > I like to maintain dictionary order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org