You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2023/06/08 17:35:03 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new pull request, #221: feat: Include dictionary member in `ArrowArrayView` struct
paleolimbot opened a new pull request, #221:
URL: https://github.com/apache/arrow-nanoarrow/pull/221
This doesn't add any features really, but ensures that one can walk `ArrowSchema`, `ArrowArray`, and `ArrowArrayView` using the same pattern. It also avoids a situation where the dictionary member was silently ignored on validation (i.e., `ArrowArrayFinishBuilding()` might return `NANOARROW_OK` for an improperly constructed array).
TODO: Update tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] lidavidm commented on a diff in pull request #221: feat: Include dictionary member in `ArrowArrayView` struct
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #221:
URL: https://github.com/apache/arrow-nanoarrow/pull/221#discussion_r1224374953
##########
src/nanoarrow/array.c:
##########
@@ -168,21 +168,40 @@ ArrowErrorCode ArrowArrayInitFromType(struct ArrowArray* array,
ArrowErrorCode ArrowArrayInitFromArrayView(struct ArrowArray* array,
struct ArrowArrayView* array_view,
struct ArrowError* error) {
- ArrowArrayInitFromType(array, array_view->storage_type);
+ NANOARROW_RETURN_NOT_OK_WITH_ERROR(
+ ArrowArrayInitFromType(array, array_view->storage_type), error);
Review Comment:
Seems like you could guard against forgetting with `-Wunused-result` and manually annotating functions with the (compiler specific) `__attribute__((warn_unused_result))` though that is rather a hassle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #221: feat: Include dictionary member in `ArrowArrayView` struct
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on code in PR #221:
URL: https://github.com/apache/arrow-nanoarrow/pull/221#discussion_r1224382025
##########
src/nanoarrow/array.c:
##########
@@ -168,21 +168,40 @@ ArrowErrorCode ArrowArrayInitFromType(struct ArrowArray* array,
ArrowErrorCode ArrowArrayInitFromArrayView(struct ArrowArray* array,
struct ArrowArrayView* array_view,
struct ArrowError* error) {
- ArrowArrayInitFromType(array, array_view->storage_type);
+ NANOARROW_RETURN_NOT_OK_WITH_ERROR(
+ ArrowArrayInitFromType(array, array_view->storage_type), error);
Review Comment:
Good idea! I will target that for 0.3 (mostly to avoid wreaking havoc on any existing usage): https://github.com/apache/arrow-nanoarrow/issues/224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] codecov-commenter commented on pull request #221: feat: Include dictionary member in `ArrowArrayView` struct
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #221:
URL: https://github.com/apache/arrow-nanoarrow/pull/221#issuecomment-1583822325
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#221](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (79616e3) into [main](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/da28e2d56c9067185e534675b646cd56d61233c1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (da28e2d) will **decrease** coverage by `0.27%`.
> The diff coverage is `75.82%`.
```diff
@@ Coverage Diff @@
## main #221 +/- ##
==========================================
- Coverage 87.88% 87.62% -0.27%
==========================================
Files 60 60
Lines 9253 9379 +126
==========================================
+ Hits 8132 8218 +86
- Misses 1121 1161 +40
```
| [Impacted Files](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [r/src/array.h](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvYXJyYXkuaA==) | `86.48% <0.00%> (ø)` | |
| [src/nanoarrow/nanoarrow.h](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy9uYW5vYXJyb3cuaA==) | `100.00% <ø> (ø)` | |
| [src/nanoarrow/nanoarrow\_types.h](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy9uYW5vYXJyb3dfdHlwZXMuaA==) | `92.75% <ø> (ø)` | |
| [src/nanoarrow/array.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy9hcnJheS5j) | `91.36% <70.14%> (-2.33%)` | :arrow_down: |
| [src/nanoarrow/array\_inline.h](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3JjL25hbm9hcnJvdy9hcnJheV9pbmxpbmUuaA==) | `89.72% <75.00%> (-0.11%)` | :arrow_down: |
| [r/R/array.R](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9SL2FycmF5LlI=) | `99.19% <100.00%> (-0.02%)` | :arrow_down: |
| [r/src/array.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvYXJyYXkuYw==) | `95.81% <100.00%> (+0.22%)` | :arrow_up: |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/221/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #221: feat: Include dictionary member in `ArrowArrayView` struct
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #221:
URL: https://github.com/apache/arrow-nanoarrow/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org