You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Jarek Cecho <ja...@apache.org> on 2014/06/06 21:31:24 UTC

Review Request 22314: SENTRY-266 Implement _HOST substitution in principal

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22314/
-----------------------------------------------------------

Review request for sentry.


Bugs: SENTRY-266
    https://issues.apache.org/jira/browse/SENTRY-266


Repository: sentry


Description
-------

I've added call to Hadoop API that will do the resolution the same way as is done in the rest of the platform.


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 62113c8 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java eefcb0a 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithKerberos.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java f3142fe 

Diff: https://reviews.apache.org/r/22314/diff/


Testing
-------

Added test case that exercise the server principal with _HOST.


Thanks,

Jarek Cecho


Re: Review Request 22314: SENTRY-266 Implement _HOST substitution in principal

Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22314/#review45038
-----------------------------------------------------------

Ship it!


LGTM

- Prasad Mujumdar


On June 6, 2014, 7:31 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22314/
> -----------------------------------------------------------
> 
> (Updated June 6, 2014, 7:31 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Bugs: SENTRY-266
>     https://issues.apache.org/jira/browse/SENTRY-266
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> I've added call to Hadoop API that will do the resolution the same way as is done in the rest of the platform.
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 62113c8 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java eefcb0a 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceWithKerberos.java PRE-CREATION 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java f3142fe 
> 
> Diff: https://reviews.apache.org/r/22314/diff/
> 
> 
> Testing
> -------
> 
> Added test case that exercise the server principal with _HOST.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>