You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by mdoelker <gi...@git.apache.org> on 2016/12/30 10:57:12 UTC
[GitHub] cordova-ios pull request #283: CB-6274 Added support for BackgroundColor pre...
GitHub user mdoelker opened a pull request:
https://github.com/apache/cordova-ios/pull/283
CB-6274 Added support for BackgroundColor preference
Supports #RGB #RRGGBB #AARRGGBB 0xRRGGBB and 0xAARRGGBB as noted in CB-6273. Fails gracefully for invalid color values (bg remains white).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mdoelker/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit 4e2e7ea856a953504956e288cbcd75bcf6391d41
Author: Malte D�lker <md...@me.com>
Date: 2016-12-30T10:45:15Z
CB-6274 Added support for BackgroundColor preference
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #283: CB-6274 Added support for BackgroundColor preference
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/283
Thanks for the PR! Unit tests still need to be added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #283: CB-6274 Added support for BackgroundColor preference
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-ios/pull/283
## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/283?src=pr) is 64.11% (diff: 100%)
> Merging [#283](https://codecov.io/gh/apache/cordova-ios/pull/283?src=pr) into [master](https://codecov.io/gh/apache/cordova-ios/branch/master?src=pr) will not change coverage
```diff
@@ master #283 diff @@
==========================================
Files 12 12
Lines 1360 1360
Methods 208 208
Messages 0 0
Branches 229 229
==========================================
Hits 872 872
Misses 488 488
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [5463937...4e2e7ea](https://codecov.io/gh/apache/cordova-ios/compare/5463937695f783e72f32d4953e13bfe4d79855ab...4e2e7ea856a953504956e288cbcd75bcf6391d41?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #283: CB-6274 Added support for BackgroundColor pre...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/283
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #283: CB-6274 Added support for BackgroundColor preference
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-ios/pull/283
That would be where I would put it, since you are testing the `colorFromColorString` from CDVViewController here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #283: CB-6274 Added support for BackgroundColor preference
Posted by mdoelker <gi...@git.apache.org>.
Github user mdoelker commented on the issue:
https://github.com/apache/cordova-ios/pull/283
Right. Any hints what the correct place for this would be? It seems like there are no tests for any other preference yet. Would adding a test for the method to the CDVViewControllerTest.m be sufficient?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org