You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/01/09 15:40:19 UTC
[GitHub] tinkerpop pull request #774: TINKERPOP-1860 valueMap(true) support/testing
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/774
TINKERPOP-1860 valueMap(true) support/testing
https://issues.apache.org/jira/browse/TINKERPOP-1860
This is the PR for master that is kin to #773 - it required additional changes to support GraphSON 3.0 as 3.0 is capable of returning complex objects for keys.
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1860-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/774.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #774
----
commit 0b94b5072a297ab883d66804c48d8a224012a90f
Author: Stephen Mallette <sp...@...>
Date: 2017-12-29T13:02:55Z
TINKERPOP-1860 Added tests for valueMap(true) variations
Note that with GraphSON 2.0 we get back string representations of T.id and T.label. That may change for GraphSON 3.0 on the 3.3.x line of code.
commit 13f1adbd4a012f413adaa584530a78c258e2d92d
Author: Stephen Mallette <sp...@...>
Date: 2018-01-08T13:07:21Z
Merge branch 'TINKERPOP-1860' into TINKERPOP-1860-master
Conflicts:
gremlin-groovy-test/src/main/groovy/org/apache/tinkerpop/gremlin/process/traversal/step/map/GroovyValueMapTest.groovy
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/ValueMapTest.java
commit 6f1b8be8ea28908de60ee4df4c201d15b755ab4a
Author: Stephen Mallette <sp...@...>
Date: 2018-01-08T14:19:00Z
TINKERPOP-1860 Added deserializer for T in gremlin-python
This allowed valueMap(true) to start working.
commit b7ed09907a1c47b4c7fee49d4d75da1aa5c71efc
Author: Jorge Bay Gondra <jo...@...>
Date: 2018-01-08T17:17:27Z
Gremlin.Net support traversal tokens in the test suite
commit bd1466b51d715e4badacd7cc7a56d5d3e53112d9
Author: Jorge Bay Gondra <jo...@...>
Date: 2018-01-08T17:59:12Z
Ignore g_V_valueMapXtrueX and g_V_valueMapXtrue_name_ageX on Gremlin.Net
----
---
[GitHub] tinkerpop pull request #774: TINKERPOP-1860 valueMap(true) support/testing
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/774
---
[GitHub] tinkerpop issue #774: TINKERPOP-1860 valueMap(true) support/testing
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/774
VOTE: +1
---
[GitHub] tinkerpop pull request #774: TINKERPOP-1860 valueMap(true) support/testing
Posted by FlorianHockmann <gi...@git.apache.org>.
Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/774#discussion_r161403447
--- Diff: gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/CommonSteps.cs ---
@@ -236,6 +237,11 @@ private static object ToLambda(string stringLambda, string graphName)
throw new IgnoreException(IgnoreReason.LambdaNotSupported);
}
+ private static object ToT(string enumName, string graphName)
+ {
+ return Enum.Parse(typeof(T), TraversalParser.GetCsharpName(enumName));
--- End diff --
Shouldn't this simply return the string representation of the `enum` for GraphSON 2.0? Stephen mentioned in TINKERPOP-1866:
> When that did happen in GraphSON 2.0, `T` values were simply converted to string.
---