You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/02/09 23:43:48 UTC
Review Request 43384: Improved error handling in
generate-endpoint-help script.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Kevin Klues.
Repository: mesos
Description
-------
Two problems:
(1) If the script exited when `current_subprocess` is None, it
would print an ugly exception stack trace.
(2) If starting the Mesos master or agent failed, it would print
an ugly exception stack trace.
Diffs
-----
support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
Diff: https://reviews.apache.org/r/43384/diff/
Testing
-------
Ran the script in error and non-error cases with the changes applied.
Thanks,
Neil Conway
Re: Review Request 43384: Fixed minor bug in
generate-endpoint-help.py.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review119973
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43384]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 19, 2016, 7:21 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:21 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the script exited when `current_subprocess` was None, it would
> print an ugly exception stack trace.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
>
> Diff: https://reviews.apache.org/r/43384/diff/
>
>
> Testing
> -------
>
> Ran the script in error and non-error cases with the changes applied.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43384: Fixed minor bug in
generate-endpoint-help.py.
Posted by Neil Conway <ne...@gmail.com>.
> On Feb. 23, 2016, 6:17 p.m., Ben Mahler wrote:
> > support/generate-endpoint-help.py, line 316
> > <https://reviews.apache.org/r/43384/diff/2/?file=1255050#file1255050line316>
> >
> > How about on_exit?
Sounds good.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review120350
-----------------------------------------------------------
On Feb. 19, 2016, 7:21 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:21 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the script exited when `current_subprocess` was None, it would
> print an ugly exception stack trace.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
>
> Diff: https://reviews.apache.org/r/43384/diff/
>
>
> Testing
> -------
>
> Ran the script in error and non-error cases with the changes applied.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43384: Fixed minor bug in
generate-endpoint-help.py.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review120350
-----------------------------------------------------------
Ship it!
support/generate-endpoint-help.py (line 316)
<https://reviews.apache.org/r/43384/#comment181782>
How about on_exit?
- Ben Mahler
On Feb. 19, 2016, 7:21 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 7:21 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the script exited when `current_subprocess` was None, it would
> print an ugly exception stack trace.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
>
> Diff: https://reviews.apache.org/r/43384/diff/
>
>
> Testing
> -------
>
> Ran the script in error and non-error cases with the changes applied.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43384: Fixed minor bug in
generate-endpoint-help.py.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 7:21 p.m.)
Review request for mesos, Ben Mahler and Kevin Klues.
Changes
-------
Revised per Kevin's comments.
Summary (updated)
-----------------
Fixed minor bug in generate-endpoint-help.py.
Repository: mesos
Description (updated)
-------
If the script exited when `current_subprocess` was None, it would
print an ugly exception stack trace.
Diffs (updated)
-----
support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
Diff: https://reviews.apache.org/r/43384/diff/
Testing
-------
Ran the script in error and non-error cases with the changes applied.
Thanks,
Neil Conway
Re: Review Request 43384: Improved error handling in
generate-endpoint-help script.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review118544
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43384]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 9, 2016, 10:43 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 10:43 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Two problems:
>
> (1) If the script exited when `current_subprocess` is None, it
> would print an ugly exception stack trace.
>
> (2) If starting the Mesos master or agent failed, it would print
> an ugly exception stack trace.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
>
> Diff: https://reviews.apache.org/r/43384/diff/
>
>
> Testing
> -------
>
> Ran the script in error and non-error cases with the changes applied.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43384: Improved error handling in
generate-endpoint-help script.
Posted by Neil Conway <ne...@gmail.com>.
> On Feb. 9, 2016, 10:51 p.m., Kevin Klues wrote:
> > I don't mind these changes. I had catches similar to these in eralier versions of this script (https://reviews.apache.org/r/43220/diff/2/), but reviews pointed to removing them in favor of printing the "ugly" stack traces.
The first behavior (printing an exception on exit if `current_subprocess` happens to be `None`) is a bug, in my opinion.
The second behavior is more debatable, I agree.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review118489
-----------------------------------------------------------
On Feb. 9, 2016, 10:43 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 10:43 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Two problems:
>
> (1) If the script exited when `current_subprocess` is None, it
> would print an ugly exception stack trace.
>
> (2) If starting the Mesos master or agent failed, it would print
> an ugly exception stack trace.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
>
> Diff: https://reviews.apache.org/r/43384/diff/
>
>
> Testing
> -------
>
> Ran the script in error and non-error cases with the changes applied.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43384: Improved error handling in
generate-endpoint-help script.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review118489
-----------------------------------------------------------
I don't mind these changes. I had catches similar to these in eralier versions of this script (https://reviews.apache.org/r/43220/diff/2/), but reviews pointed to removing them in favor of printing the "ugly" stack traces.
- Kevin Klues
On Feb. 9, 2016, 10:43 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 10:43 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Two problems:
>
> (1) If the script exited when `current_subprocess` is None, it
> would print an ugly exception stack trace.
>
> (2) If starting the Mesos master or agent failed, it would print
> an ugly exception stack trace.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
>
> Diff: https://reviews.apache.org/r/43384/diff/
>
>
> Testing
> -------
>
> Ran the script in error and non-error cases with the changes applied.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 43384: Improved error handling in
generate-endpoint-help script.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43384/#review119710
-----------------------------------------------------------
support/generate-endpoint-help.py (lines 295 - 299)
<https://reviews.apache.org/r/43384/#comment181052>
I would exclude this.
The stack trace should be more informative about what actually went wrong.
support/generate-endpoint-help.py (lines 313 - 317)
<https://reviews.apache.org/r/43384/#comment181051>
I would exclude this.
The stack trace should be more informative about what actually went wrong.
support/generate-endpoint-help.py (lines 324 - 332)
<https://reviews.apache.org/r/43384/#comment181054>
This is clearly a bug and should be fixed as you have done.
- Kevin Klues
On Feb. 9, 2016, 10:43 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43384/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 10:43 p.m.)
>
>
> Review request for mesos, Ben Mahler and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Two problems:
>
> (1) If the script exited when `current_subprocess` is None, it
> would print an ugly exception stack trace.
>
> (2) If starting the Mesos master or agent failed, it would print
> an ugly exception stack trace.
>
>
> Diffs
> -----
>
> support/generate-endpoint-help.py 28333847e5603c942f25ec9d9a0429bd676f4541
>
> Diff: https://reviews.apache.org/r/43384/diff/
>
>
> Testing
> -------
>
> Ran the script in error and non-error cases with the changes applied.
>
>
> Thanks,
>
> Neil Conway
>
>