[jira] [Comment Edited] (PHOENIX-5902) Document or fix new compat jar behavior.

["Lars Hofhansl (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125122#comment-17125122 ] 

Lars Hofhansl edited comment on PHOENIX-5902 at 6/3/20, 4:43 PM:
-----------------------------------------------------------------

Actually I think it's nicer to keep the compat jar out of the server jar, but to move (or link) the compat jars into the same directory as the server jar. That way we can ship one version of Phoenix that could include compat jars for all supported versions of HBase).

(which nicely also means that both the Phoenix release, nor the server jar needs to carry the name of the HBase version anymore)


was (Author: lhofhansl):
Actually I think it's nicer to keep the compat jar out of the server jar, but to move (or link) the compat jars into the same directory as the server jar. That way we can ship one version of Phoenix that could include compat jars for all supported versions of HBase).

 

> Document or fix new compat jar behavior.
> ----------------------------------------
>
>                 Key: PHOENIX-5902
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5902
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.16.0
>            Reporter: Lars Hofhansl
>            Assignee: Istvan Toth
>            Priority: Blocker
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-5902.4.x.v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> After PHOENIX-5808 (I think), the compat classes are no longer included in Phoenix' server jar.
> This causes the HBase regionservers to fail with:
> 2020-05-15 15:35:36,098 FATAL [RS_OPEN_PRIORITY_REGION-host:16201-1] regionserver.HRegionServer: ABORTING region server think,16201,1589581955446: The coprocessor org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver threw java.lang.NoClassDefFoundError: org/apache/phoenix/compat/hbase/CompatRpcControllerFactory
> It is now necessary to copy lib/phoenix-hbase-compat-1.5.0-4.16.0-SNAPSHOT.jar into HBase's lib directory as well.
> The jar in the Phoenix directory is called: phoenix-server-4.16.0-SNAPSHOT-hbase-1.5.jar, so I do not see why it could not include the compatibility classes.
> Alternatively we can rename that jar to just phoenix-server-4.16.0-SNAPSHOT.jar and place the compatbility jar in Phoenix' top level directory and document the change.
> (Of course a release would not have SNAPSHOT in the name...)
> Marking as blocker for 4.16.0, because as is, it will bring HBase down hard upon upgrade if this is not kept in mind.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)