[jira] [Commented] (WICKET-4338) POST params ignored by IPageParametersEncoder#decodePageParameters()

["Lucas Moten (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208799#comment-13208799 ] 

Lucas Moten commented on WICKET-4338:
-------------------------------------

The fix for this appears to break another scenario, which I don't believe is being tested.   Specifically, that where 2 (or more) parameters are being set with the same name and value.
For example:  page?s=1&s=2&s=1 will end up yeilding page?s=1&s=2

PageParameters.decodePageParameters was altered to call requestParameters.getParameterValues(paramName)
CombinedRequestParametersAdapter.getParameterValues(final String name) explicitly filters out adding a value if it is already contained within the list.
Since that logic was in place before this patch, I don't have much to go on to determine why the duplicate values are filtered out and what would possibly break if this code was modified to just add the values regardless of them being in the result already
                
> POST params ignored by IPageParametersEncoder#decodePageParameters()
> --------------------------------------------------------------------
>
>                 Key: WICKET-4338
>                 URL: https://issues.apache.org/jira/browse/WICKET-4338
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.5.3
>         Environment: JDK 1.6.0_29, Mac OSX
>            Reporter: George Armhold
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5.4, 6.0.0
>
>         Attachments: missing-params.tar.gz
>
>
> As per this conversation: http://apache-wicket.1842946.n4.nabble.com/how-to-get-https-port-number-in-Wicket-1-5-td4295139.html
> it seems that POST params are not properly processed and made available as PageParameters. Can anyone say whether this is intended behavior or not? I will attach a Quickstart to demonstrate.
> Martin's proposed fix is straightforward, but I am not comfortable enough with Wicket internals to say whether or not this would break something.
> Thanks

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira