You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/02/11 00:35:59 UTC

Review Request 43435: Change StartSlave test helper to take shared_ptr arguments.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43435/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske and Artem Harutyunyan.


Bugs: MESOS-4633
    https://issues.apache.org/jira/browse/MESOS-4633


Repository: mesos


Description
-------

This modifies all variants of `MesosTest::StartSlave` to take `shared_ptr` instead of raw pointers.  Ownership of the pointer is shared between the test and the `Slave` object created by `Cluster::Slaves::start`.

Also removed the containerizer cleanup logic inside MesosTest, which is no longer necessary with `shared_ptr`.


Diffs
-----

  src/tests/cluster.hpp 99a785ab0d4ee1a1e745202d2551de58a7631a85 
  src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
  src/tests/mesos.hpp c0997dbacf8753149caba0a8b2406afc35a4845f 
  src/tests/mesos.cpp e0f641c6828833de13a0a233e39ff6dc3f343d5c 

Diff: https://reviews.apache.org/r/43435/diff/


Testing
-------

Tests are run at the very, very end of this review chain.


Thanks,

Joseph Wu