You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2008/08/20 18:37:18 UTC

Re: svn commit: r32538 - trunk/subversion/libsvn_ra_neon

rhuijben@tigris.org writes:
> Log:
> * subversion/libsvn_ra_neon/session.c
>  (exchange_capabilities): Following up to r32417, stop setting up client 
>    capabilities for this request, because they will now automatically 
>    be added on every request by svn_ra_neon__request_dispatch.
>
> --- trunk/subversion/libsvn_ra_neon/session.c
> +++ trunk/subversion/libsvn_ra_neon/session.c
> @@ -793,10 +793,6 @@ exchange_capabilities(svn_ra_neon__sessi
>  
>    rar = svn_ra_neon__request_create(ras, "OPTIONS", ras->url->data, pool);
>  
> -  ne_add_request_header(rar->ne_req, "DAV", SVN_DAV_NS_DAV_SVN_DEPTH);
> -  ne_add_request_header(rar->ne_req, "DAV", SVN_DAV_NS_DAV_SVN_MERGEINFO);
> -  ne_add_request_header(rar->ne_req, "DAV", SVN_DAV_NS_DAV_SVN_LOG_REVPROPS);
> -
>    err = svn_ra_neon__request_dispatch(&http_ret_code, rar,
>                                        NULL, NULL, 200, 0, pool);
>    if (err)

Since this function is called 'exchange_capabilities', it might be good
to leave a comment in place of the removed code, explaining why we're
still sending the capabilities here even though it doesn't look like we
are.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org