You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by js...@apache.org on 2007/10/29 07:23:27 UTC
svn commit: r589508 - in
/incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl:
CompositeBuilderImpl.java ProblemImpl.java
Author: jsdelfino
Date: Sun Oct 28 23:23:26 2007
New Revision: 589508
URL: http://svn.apache.org/viewvc?rev=589508&view=rev
Log:
Putting the severity in the message string is not necessary as the logger already prints the severity in front of each message.
Modified:
incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBuilderImpl.java
incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ProblemImpl.java
Modified: incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBuilderImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBuilderImpl.java?rev=589508&r1=589507&r2=589508&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBuilderImpl.java (original)
+++ incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/CompositeBuilderImpl.java Sun Oct 28 23:23:26 2007
@@ -19,6 +19,7 @@
package org.apache.tuscany.sca.assembly.builder.impl;
import java.util.List;
+import java.util.logging.Level;
import java.util.logging.Logger;
import org.apache.tuscany.sca.assembly.AssemblyFactory;
@@ -60,7 +61,7 @@
CompositeBuilderMonitor monitor) {
if (monitor == null) {
- // Create a default monitor that does nothing.
+ // Create a default monitor that logs using the JDK logger.
monitor = new CompositeBuilderMonitor() {
public void problem(Problem problem) {
if (problem.getSeverity() == Severity.INFO) {
@@ -68,7 +69,11 @@
} else if (problem.getSeverity() == Severity.WARNING) {
logger.warning(problem.toString());
} else if (problem.getSeverity() == Severity.ERROR) {
- logger.severe(problem.toString());
+ if (problem.getCause() != null) {
+ logger.log(Level.SEVERE, problem.toString(), problem.getCause());
+ } else {
+ logger.severe(problem.toString());
+ }
}
}
};
Modified: incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ProblemImpl.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ProblemImpl.java?rev=589508&r1=589507&r2=589508&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ProblemImpl.java (original)
+++ incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/ProblemImpl.java Sun Oct 28 23:23:26 2007
@@ -19,9 +19,6 @@
package org.apache.tuscany.sca.assembly.builder.impl;
-import java.io.PrintWriter;
-import java.io.StringWriter;
-
import org.apache.tuscany.sca.assembly.builder.Problem;
/**
@@ -100,18 +97,16 @@
@Override
public String toString() {
- StringWriter sw = new StringWriter();
- PrintWriter writer = new PrintWriter(sw);
- writer.format("[%s] %s %s", severity, message, resource);
- //PrintUtil util = new PrintUtil(writer, false);
- //if (model != null) {
- // writer.println();
- // util.print(model);
- //}
- if (cause != null) {
- writer.println();
- cause.printStackTrace(writer);
+ StringBuffer sb = new StringBuffer();
+ if (message != null) {
+ sb.append(message);
+ }
+ if (resource != null) {
+ if (sb.length() != 0) {
+ sb.append(" - ");
+ }
+ sb.append(resource.toString());
}
- return sw.toString();
+ return sb.toString();
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org