You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/11/30 15:30:09 UTC
[GitHub] [incubator-eventmesh] ruanwenjun opened a new pull request #621: Change TCP Decoder and Encoder
ruanwenjun opened a new pull request #621:
URL: https://github.com/apache/incubator-eventmesh/pull/621
Since currently the TCP Encoder and Decoder is relied by runtime and sdk. So we don't move the Protocol plugin to Encoder and Decoder. In the current code, when sdk pub message to runtime, decoder will decoder the tcp package and deserialize the message to json string, and protocol plugin will deserialize the json string to target message.
And runtime publish message to sdk, the sdk also need to deserialize the message json string, this code will duplicate in protocol plugin and sdk, we can optimize this in the future.
We can not use JsonUtils to deserialize CloudEvent, since there are no NoArgsConstructor in CloudEvent, it might need to write code to do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on pull request #621: Change TCP Decoder and Encoder
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #621:
URL: https://github.com/apache/incubator-eventmesh/pull/621#issuecomment-982746648
@xwm1992 Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #621: Change TCP Decoder and Encoder
Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #621:
URL: https://github.com/apache/incubator-eventmesh/pull/621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org