You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/09/02 07:41:14 UTC
[GitHub] [incubator-pinot] suvodeep-pyne opened a new pull request #5961: [TE] Added helm deployment for ThirdEye
suvodeep-pyne opened a new pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961
## Description
Creating a helm application for ThirdEye to work with pinot quickstart
right off the box. The current change installs MySQL with the initial
set of tables. This creates thirdeye frontend and backend pods
#### Caveats
- The initdb.sql needs to be updated regularly which is an overhead. To be refactored later.
- Using the create-schema.sql is not possible at the moment since the script has errors with MySQL 5.7.
No backward incompatible changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961#issuecomment-686659050
Hi @devinay
I like all your comments. And I think we are aligned on most of the issues. Think of this as the alpha version of the deployment. As we go forward, we'll streamline configuration and focus of scalability.
Some thoughts:
- The intent of this distribution is to help new/existing users with a template to kickstart ThirdEye with the minimal amount of effort
- Going forward, the goal is to make this distribution ready for production
- Regarding MySQL: We want people to be able to plugin their existing SQL service in the future. However, currently we are just trying to make things simple for new users so that they can jumpstart their application with minimal effort.
- Regarding scheduler, worker: Agreed. This is an alpha version. We'll be enhancing this further. PR's welcome :) However, long term, we are also looking at architectural simplifications that could make TE more reliable. For example, having a distributed scheduler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on a change in pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961#discussion_r482352289
##########
File path: kubernetes/helm/thirdeye/templates/frontend/service.yaml
##########
@@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: Service
+metadata:
+ name: {{ include "thirdeye.frontend.fullname" . }}
+ labels:
+ app: {{ include "thirdeye.name" . }}
+ chart: {{ include "thirdeye.chart" . }}
+ component: {{ .Values.frontend.name }}
+ release: {{ .Release.Name }}
+ heritage: {{ .Release.Service }}
+spec:
+ type: LoadBalancer
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] devinay commented on pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
devinay commented on pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961#issuecomment-686246344
This is good. I had a few additional comments:
It would probably make sense to have 3 types of installation :
frontend, worker and scheduler : So users should be able to install these 3 kinds of nodes either by changing something in values.yaml or by passing params to helm. This is convenient as each of these 3 node types could live in different VPC's or be provisioned in different env's.
Could the mysql initialization be treated as an independent concern -- because its a one-time thing. It may not be a bad thing to assume that the db is already available and initialized and not treat DB upgrades via helm at all. DB install / backup / schema migration is an independent and mature concern with its own tools like liquibase. In theory, thirdeye should be able to work with any database, maybe even NoSQL ones.
The bulk of operation load (IMHO) comes because we want to scale or change the config of some existing cluster, we want to increase the size of the back end, add new config variables, override old ones, support new datasources or detection algos. This would help upgrade / scale up a cluster to keep pace with code changes and load requirements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] apucher commented on a change in pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
apucher commented on a change in pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961#discussion_r482256834
##########
File path: kubernetes/helm/thirdeye/templates/common/configmap.yaml
##########
@@ -0,0 +1,252 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: thirdeye-pinot-quickstart-datasource-config
+data:
+ persistence.yml: |-
+ databaseConfiguration:
+ url: jdbc:mysql://{{ .Release.Name }}-mysql/thirdeye
+ user: {{ .Values.mysql.mysqlUser }}
+ password: {{ .Values.mysql.mysqlPassword }}
+ driver: com.mysql.jdbc.Driver
+ dashboard.yml: |-
+ authConfig:
+ authEnabled: false
+ authKey: ""
+ ldapUrl: ""
+ domainSuffix: []
+ cacheTTL: 3600
+ cookieTTL: 604800
+ resourceConfig: []
+ rootCause:
+ definitionsPath: rca.yml
+ parallelism: 5
+ formatters:
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.AnomalyEventFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ThirdEyeEventFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.MetricEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DimensionEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ServiceEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DefaultEventEntityFormatter
+ dashboardHost: "http://localhost:1426"
+ failureFromAddress: thirdeye@localhost
+ failureToAddress: user@localhost
+ alerterConfiguration:
+ smtpConfiguration:
+ smtpHost: localhost
+ smtpPort: 25
+ logging:
+ level: INFO
+ loggers:
+ org.apache.pinot: INFO
+
+ server:
+ type: default
+ applicationConnectors:
+ - type: http
+ port: 1426
+ adminConnectors:
+ - type: http
+ port: 1427
+ requestLog:
+ type: external
+ whitelistDatasets: []
+ swagger:
+ resourcePackage: "org.apache.pinot.thirdeye.dashboard.resources,org.apache.pinot.thirdeye.dashboard.resources.v2,org.apache.pinot.thirdeye.anomaly.onboard,org.apache.pinot.thirdeye.detection,org.apache.pinot.thirdeye.detection.yaml"
+
+ detector.yml: |-
+ logging:
+ level: INFO
+ loggers:
+ org.hibernate.engine.internal: WARN
+ server:
+ type: default
+ rootPath: '/api/*'
+ applicationContextPath: /
+ adminContextPath: /admin
+ applicationConnectors:
+ - type: http
+ port: 1867
+ adminConnectors:
+ - type: http
+ port: 1868
+ alert: false
+ autoload: true
+ # autoOnboardConfiguration:
+ # runFrequency: 10s
+
+ classifier: false
Review comment:
We'll need separate "detector.yml" files for the **scheduler backend** and regular **worker backends**. Scheduler can be a worker too, but there can only be one scheduler active at a time.
**Scheduler**
alert: true
autoload: true
classifier: true
holidayEventsLoader: true
monitor: true
scheduler: true
worker: true/false
detectionPipeline: true
detectionAlert: true
**Worker**
alert: false
autoload: false
classifier: false
holidayEventsLoader: false
monitor: false
scheduler: false
worker: true
detectionPipeline: false
detectionAlert: false
##########
File path: kubernetes/helm/thirdeye/templates/frontend/service.yaml
##########
@@ -0,0 +1,38 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: Service
+metadata:
+ name: {{ include "thirdeye.frontend.fullname" . }}
+ labels:
+ app: {{ include "thirdeye.name" . }}
+ chart: {{ include "thirdeye.chart" . }}
+ component: {{ .Values.frontend.name }}
+ release: {{ .Release.Name }}
+ heritage: {{ .Release.Service }}
+spec:
+ type: LoadBalancer
Review comment:
should be configurable
##########
File path: kubernetes/helm/thirdeye/templates/common/configmap.yaml
##########
@@ -0,0 +1,252 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: thirdeye-pinot-quickstart-datasource-config
+data:
+ persistence.yml: |-
+ databaseConfiguration:
+ url: jdbc:mysql://{{ .Release.Name }}-mysql/thirdeye
+ user: {{ .Values.mysql.mysqlUser }}
+ password: {{ .Values.mysql.mysqlPassword }}
+ driver: com.mysql.jdbc.Driver
+ dashboard.yml: |-
+ authConfig:
+ authEnabled: false
+ authKey: ""
+ ldapUrl: ""
+ domainSuffix: []
+ cacheTTL: 3600
+ cookieTTL: 604800
+ resourceConfig: []
+ rootCause:
+ definitionsPath: rca.yml
+ parallelism: 5
+ formatters:
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.AnomalyEventFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ThirdEyeEventFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.MetricEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DimensionEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ServiceEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DefaultEventEntityFormatter
+ dashboardHost: "http://localhost:1426"
+ failureFromAddress: thirdeye@localhost
+ failureToAddress: user@localhost
+ alerterConfiguration:
+ smtpConfiguration:
+ smtpHost: localhost
+ smtpPort: 25
+ logging:
+ level: INFO
+ loggers:
+ org.apache.pinot: INFO
+
+ server:
+ type: default
+ applicationConnectors:
+ - type: http
+ port: 1426
+ adminConnectors:
+ - type: http
+ port: 1427
+ requestLog:
+ type: external
+ whitelistDatasets: []
+ swagger:
+ resourcePackage: "org.apache.pinot.thirdeye.dashboard.resources,org.apache.pinot.thirdeye.dashboard.resources.v2,org.apache.pinot.thirdeye.anomaly.onboard,org.apache.pinot.thirdeye.detection,org.apache.pinot.thirdeye.detection.yaml"
+
+ detector.yml: |-
+ logging:
+ level: INFO
+ loggers:
+ org.hibernate.engine.internal: WARN
+ server:
+ type: default
+ rootPath: '/api/*'
+ applicationContextPath: /
+ adminContextPath: /admin
+ applicationConnectors:
+ - type: http
+ port: 1867
+ adminConnectors:
+ - type: http
+ port: 1868
+ alert: false
+ autoload: true
+ # autoOnboardConfiguration:
+ # runFrequency: 10s
+
+ classifier: false
Review comment:
also, worker CAN omit holidayLoaderConfiguration and SHOULD omit mockEventsLoaderconfiguration
##########
File path: kubernetes/helm/thirdeye/values.yaml
##########
@@ -0,0 +1,73 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Default values for ThirdEye Deployment
+
+image:
+ repository: apachepinot/thirdeye
+ tag: latest
+ pullPolicy: IfNotPresent
+
+frontend:
+ enabled: true
+ name: frontend
+ replicaCount: 1
+ port: 1426
+ adminport: 1427
+
+ resources: {}
+ nodeSelector: {}
+ tolerations: []
+ affinity: {}
+ podAnnotations: {}
+
+
+backend:
+ enabled: true
+ name: backend
+ replicaCount: 1
+ port: 1867
+ adminport: 1868
+
+ resources: {}
+ nodeSelector: {}
+ tolerations: []
+ affinity: {}
+ podAnnotations: {}
+
+# Persistence layer configuration
+mysql:
+ mysqlRootPassword: password
Review comment:
this part is pretty ugly. I wonder what's the best practice for retaining the mysql secret over redeploy without exposing this here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] apucher commented on a change in pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
apucher commented on a change in pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961#discussion_r482256834
##########
File path: kubernetes/helm/thirdeye/templates/common/configmap.yaml
##########
@@ -0,0 +1,252 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: thirdeye-pinot-quickstart-datasource-config
+data:
+ persistence.yml: |-
+ databaseConfiguration:
+ url: jdbc:mysql://{{ .Release.Name }}-mysql/thirdeye
+ user: {{ .Values.mysql.mysqlUser }}
+ password: {{ .Values.mysql.mysqlPassword }}
+ driver: com.mysql.jdbc.Driver
+ dashboard.yml: |-
+ authConfig:
+ authEnabled: false
+ authKey: ""
+ ldapUrl: ""
+ domainSuffix: []
+ cacheTTL: 3600
+ cookieTTL: 604800
+ resourceConfig: []
+ rootCause:
+ definitionsPath: rca.yml
+ parallelism: 5
+ formatters:
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.AnomalyEventFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ThirdEyeEventFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.MetricEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DimensionEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ServiceEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DefaultEventEntityFormatter
+ dashboardHost: "http://localhost:1426"
+ failureFromAddress: thirdeye@localhost
+ failureToAddress: user@localhost
+ alerterConfiguration:
+ smtpConfiguration:
+ smtpHost: localhost
+ smtpPort: 25
+ logging:
+ level: INFO
+ loggers:
+ org.apache.pinot: INFO
+
+ server:
+ type: default
+ applicationConnectors:
+ - type: http
+ port: 1426
+ adminConnectors:
+ - type: http
+ port: 1427
+ requestLog:
+ type: external
+ whitelistDatasets: []
+ swagger:
+ resourcePackage: "org.apache.pinot.thirdeye.dashboard.resources,org.apache.pinot.thirdeye.dashboard.resources.v2,org.apache.pinot.thirdeye.anomaly.onboard,org.apache.pinot.thirdeye.detection,org.apache.pinot.thirdeye.detection.yaml"
+
+ detector.yml: |-
+ logging:
+ level: INFO
+ loggers:
+ org.hibernate.engine.internal: WARN
+ server:
+ type: default
+ rootPath: '/api/*'
+ applicationContextPath: /
+ adminContextPath: /admin
+ applicationConnectors:
+ - type: http
+ port: 1867
+ adminConnectors:
+ - type: http
+ port: 1868
+ alert: false
+ autoload: true
+ # autoOnboardConfiguration:
+ # runFrequency: 10s
+
+ classifier: false
Review comment:
We'll need separate "detector.yml" files for the **scheduler backend** and regular **worker backends**. Scheduler can be a worker too, but there can only be one scheduler active at a time.
**Scheduler**
alert: true
autoload: true
classifier: true
holidayEventsLoader: true
monitor: true
scheduler: true
worker: true/false (should be configurable)
detectionPipeline: true
detectionAlert: true
mockEventsLoader: true/false (should be configurable)
**Worker**
alert: false
autoload: false
classifier: false
holidayEventsLoader: false
monitor: false
scheduler: false
worker: true
detectionPipeline: false
detectionAlert: false
mockEventsLoader: false
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on a change in pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961#discussion_r482403994
##########
File path: kubernetes/helm/thirdeye/templates/common/configmap.yaml
##########
@@ -0,0 +1,252 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: thirdeye-pinot-quickstart-datasource-config
+data:
+ persistence.yml: |-
+ databaseConfiguration:
+ url: jdbc:mysql://{{ .Release.Name }}-mysql/thirdeye
+ user: {{ .Values.mysql.mysqlUser }}
+ password: {{ .Values.mysql.mysqlPassword }}
+ driver: com.mysql.jdbc.Driver
+ dashboard.yml: |-
+ authConfig:
+ authEnabled: false
+ authKey: ""
+ ldapUrl: ""
+ domainSuffix: []
+ cacheTTL: 3600
+ cookieTTL: 604800
+ resourceConfig: []
+ rootCause:
+ definitionsPath: rca.yml
+ parallelism: 5
+ formatters:
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.AnomalyEventFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ThirdEyeEventFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.MetricEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DimensionEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.ServiceEntityFormatter
+ - org.apache.pinot.thirdeye.dashboard.resources.v2.rootcause.DefaultEventEntityFormatter
+ dashboardHost: "http://localhost:1426"
+ failureFromAddress: thirdeye@localhost
+ failureToAddress: user@localhost
+ alerterConfiguration:
+ smtpConfiguration:
+ smtpHost: localhost
+ smtpPort: 25
+ logging:
+ level: INFO
+ loggers:
+ org.apache.pinot: INFO
+
+ server:
+ type: default
+ applicationConnectors:
+ - type: http
+ port: 1426
+ adminConnectors:
+ - type: http
+ port: 1427
+ requestLog:
+ type: external
+ whitelistDatasets: []
+ swagger:
+ resourcePackage: "org.apache.pinot.thirdeye.dashboard.resources,org.apache.pinot.thirdeye.dashboard.resources.v2,org.apache.pinot.thirdeye.anomaly.onboard,org.apache.pinot.thirdeye.detection,org.apache.pinot.thirdeye.detection.yaml"
+
+ detector.yml: |-
+ logging:
+ level: INFO
+ loggers:
+ org.hibernate.engine.internal: WARN
+ server:
+ type: default
+ rootPath: '/api/*'
+ applicationContextPath: /
+ adminContextPath: /admin
+ applicationConnectors:
+ - type: http
+ port: 1867
+ adminConnectors:
+ - type: http
+ port: 1868
+ alert: false
+ autoload: true
+ # autoOnboardConfiguration:
+ # runFrequency: 10s
+
+ classifier: false
Review comment:
I'm creating a composite worker/scheduler pod for now just to keep things simple. I plan to split these up later on since these configurations hasn't been tested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] apucher merged pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
apucher merged pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] apucher commented on a change in pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
apucher commented on a change in pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961#discussion_r482485691
##########
File path: kubernetes/helm/thirdeye/values.yaml
##########
@@ -0,0 +1,73 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Default values for ThirdEye Deployment
+
+image:
+ repository: apachepinot/thirdeye
+ tag: latest
+ pullPolicy: IfNotPresent
+
+frontend:
+ enabled: true
+ name: frontend
+ replicaCount: 1
+ port: 1426
+ adminport: 1427
+
+ resources: {}
+ nodeSelector: {}
+ tolerations: []
+ affinity: {}
+ podAnnotations: {}
+
+
+backend:
+ enabled: true
+ name: backend
+ replicaCount: 1
+ port: 1867
+ adminport: 1868
+
+ resources: {}
+ nodeSelector: {}
+ tolerations: []
+ affinity: {}
+ podAnnotations: {}
+
+# Persistence layer configuration
+mysql:
+ mysqlRootPassword: password
Review comment:
ok let's do this next iteration then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] suvodeep-pyne commented on a change in pull request #5961: [TE] Added helm deployment for ThirdEye
Posted by GitBox <gi...@apache.org>.
suvodeep-pyne commented on a change in pull request #5961:
URL: https://github.com/apache/incubator-pinot/pull/5961#discussion_r482437721
##########
File path: kubernetes/helm/thirdeye/values.yaml
##########
@@ -0,0 +1,73 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Default values for ThirdEye Deployment
+
+image:
+ repository: apachepinot/thirdeye
+ tag: latest
+ pullPolicy: IfNotPresent
+
+frontend:
+ enabled: true
+ name: frontend
+ replicaCount: 1
+ port: 1426
+ adminport: 1427
+
+ resources: {}
+ nodeSelector: {}
+ tolerations: []
+ affinity: {}
+ podAnnotations: {}
+
+
+backend:
+ enabled: true
+ name: backend
+ replicaCount: 1
+ port: 1867
+ adminport: 1868
+
+ resources: {}
+ nodeSelector: {}
+ tolerations: []
+ affinity: {}
+ podAnnotations: {}
+
+# Persistence layer configuration
+mysql:
+ mysqlRootPassword: password
Review comment:
I have kept install.sh extendible to easily override helm parameters. That should give a user some flexibility to feed in secrets. However, this part needs to be resolved in a better way. Since this is a demo setup, I am thinking of starting with this for now as we move to better solutions with k8s secrets, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org