You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/18 07:06:47 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
dongjoon-hyun opened a new pull request #30084:
URL: https://github.com/apache/spark/pull/30084
### What changes were proposed in this pull request?
This PR aims to detect duplicate `mountPath` and stop the job.
### Why are the changes needed?
If there is a conflict on `mountPath`, the pod is created and repeats the following error messages and keeps running. Spark job should not keep running and wasting the cluster resources.
```
$ k get pod -l 'spark-role in (driver,executor)'
NAME READY STATUS RESTARTS AGE
tpcds 1/1 Running 0 33m
```
```
20/10/18 05:09:26 WARN ExecutorPodsSnapshotsStoreImpl: Exception when notifying snapshot subscriber.
io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: POST at: ...
Message: Pod "tpcds-exec-1" is invalid: spec.containers[0].volumeMounts[1].mountPath:
Invalid value: "/data1": must be unique.
...
```
We had better fail at Spark side.
### Does this PR introduce _any_ user-facing change?
Yes, but this is a bug fix.
### How was this patch tested?
Pass the CI with the newly added test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711290846
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711286672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711131353
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34561/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30084:
URL: https://github.com/apache/spark/pull/30084#discussion_r507183220
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala
##########
@@ -49,6 +49,11 @@ private[spark] class MountVolumesFeatureStep(conf: KubernetesConf)
private def constructVolumes(
volumeSpecs: Iterable[KubernetesVolumeSpec]
): Iterable[(VolumeMount, Volume)] = {
+ val duplicateMountPaths = volumeSpecs.map(_.mountPath).toSeq.groupBy(identity).collect {
+ case (x, ys) if ys.length > 1 => s"`$x`"
+ }
+ require(duplicateMountPaths.isEmpty,
+ s"Found duplicated mountPath: ${duplicateMountPaths.mkString(",")}")
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711128122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711286672
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711329381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711133712
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34561/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711127087
**[Test build #129955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129955/testReport)** for PR 30084 at commit [`bfa5a9f`](https://github.com/apache/spark/commit/bfa5a9f8ffc6108584616625661fb34ee576f6f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711133717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711283012
Thank you for review and approval, @viirya !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711279793
**[Test build #129961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129961/testReport)** for PR 30084 at commit [`8ab6b88`](https://github.com/apache/spark/commit/8ab6b8854dcc669e1b21e7354bdd781a0d4911bd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30084:
URL: https://github.com/apache/spark/pull/30084#discussion_r507183133
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala
##########
@@ -49,6 +49,11 @@ private[spark] class MountVolumesFeatureStep(conf: KubernetesConf)
private def constructVolumes(
volumeSpecs: Iterable[KubernetesVolumeSpec]
): Iterable[(VolumeMount, Volume)] = {
+ val duplicateMountPaths = volumeSpecs.map(_.mountPath).toSeq.groupBy(identity).collect {
+ case (x, ys) if ys.length > 1 => s"`$x`"
Review comment:
Thanks. Sure!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30084:
URL: https://github.com/apache/spark/pull/30084#discussion_r507042357
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala
##########
@@ -49,6 +49,11 @@ private[spark] class MountVolumesFeatureStep(conf: KubernetesConf)
private def constructVolumes(
volumeSpecs: Iterable[KubernetesVolumeSpec]
): Iterable[(VolumeMount, Volume)] = {
+ val duplicateMountPaths = volumeSpecs.map(_.mountPath).toSeq.groupBy(identity).collect {
+ case (x, ys) if ys.length > 1 => s"`$x`"
+ }
+ require(duplicateMountPaths.isEmpty,
+ s"Found duplicated mountPath: ${duplicateMountPaths.mkString(",")}")
Review comment:
I would add one space at `mkString(",")`: `mkString(", ")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711286535
**[Test build #129961 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129961/testReport)** for PR 30084 at commit [`8ab6b88`](https://github.com/apache/spark/commit/8ab6b8854dcc669e1b21e7354bdd781a0d4911bd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30084:
URL: https://github.com/apache/spark/pull/30084
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30084:
URL: https://github.com/apache/spark/pull/30084#discussion_r507042244
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/MountVolumesFeatureStep.scala
##########
@@ -49,6 +49,11 @@ private[spark] class MountVolumesFeatureStep(conf: KubernetesConf)
private def constructVolumes(
volumeSpecs: Iterable[KubernetesVolumeSpec]
): Iterable[(VolumeMount, Volume)] = {
+ val duplicateMountPaths = volumeSpecs.map(_.mountPath).toSeq.groupBy(identity).collect {
+ case (x, ys) if ys.length > 1 => s"`$x`"
Review comment:
quick question: why is it using backquotes? I thought single quote makes more sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711128098
**[Test build #129955 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129955/testReport)** for PR 30084 at commit [`bfa5a9f`](https://github.com/apache/spark/commit/bfa5a9f8ffc6108584616625661fb34ee576f6f6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711329381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711329361
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34567/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711128122
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711303429
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34567/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711279793
**[Test build #129961 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129961/testReport)** for PR 30084 at commit [`8ab6b88`](https://github.com/apache/spark/commit/8ab6b8854dcc669e1b21e7354bdd781a0d4911bd).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711133717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30084: [SPARK-33175][K8S] Detect duplicated mountPaths and fail at Spark side
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30084:
URL: https://github.com/apache/spark/pull/30084#issuecomment-711127087
**[Test build #129955 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129955/testReport)** for PR 30084 at commit [`bfa5a9f`](https://github.com/apache/spark/commit/bfa5a9f8ffc6108584616625661fb34ee576f6f6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org