You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "ReneEnjilian (via GitHub)" <gi...@apache.org> on 2025/03/01 23:56:02 UTC
[PR] Improve test coverage for rewrite package [systemds]
ReneEnjilian opened a new pull request, #2240:
URL: https://github.com/apache/systemds/pull/2240
This pull request is the first in a series aimed at enhancing the test coverage of the rewrite package. Specifically, it adds additional tests for the algebraic simplifications defined in `RewriteAlgebraicSimplificationStatic`. The goal is also to proactively identify potential bugs, similar to our previous efforts. No bugs were found in this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve test coverage for rewrite package [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2240:
URL: https://github.com/apache/systemds/pull/2240#issuecomment-2692718205
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2240?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 72.46%. Comparing base [(`78b23cf`)](https://app.codecov.io/gh/apache/systemds/commit/78b23cf41756a8c86583c0d61f2a1ced812e565d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`27f09d8`)](https://app.codecov.io/gh/apache/systemds/commit/27f09d8077c54d1ef3c48ba69f9d334bdf6b4867?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2240 +/- ##
============================================
- Coverage 72.46% 72.46% -0.01%
- Complexity 45453 45462 +9
============================================
Files 1469 1469
Lines 170893 170893
Branches 33325 33325
============================================
- Hits 123846 123845 -1
- Misses 37630 37640 +10
+ Partials 9417 9408 -9
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2240?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve test coverage for rewrite package [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2240:
URL: https://github.com/apache/systemds/pull/2240#issuecomment-2692661033
Thanks @ReneEnjilian - could you please address the failing rewrite tests (I just kicked them off again, but there seem to be systematic failures).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve test coverage for rewrite package [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 commented on PR #2240:
URL: https://github.com/apache/systemds/pull/2240#issuecomment-2694810354
LGTM - thanks @ReneEnjilian for the effort improving our test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve test coverage for rewrite package [systemds]
Posted by "ReneEnjilian (via GitHub)" <gi...@apache.org>.
ReneEnjilian commented on PR #2240:
URL: https://github.com/apache/systemds/pull/2240#issuecomment-2692707462
I implemented a fix and hope that this resolves the issue now. The error does not occur on my machine but from what I can see is that R struggled with the class type of the result matrix. Changing `outer(v, 1:m, "==")` to `outer(as.vector(v), 1:m, "==")` should resolve the error because R is now recognized as type matrix and not only as type array anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve test coverage for rewrite package [systemds]
Posted by "mboehm7 (via GitHub)" <gi...@apache.org>.
mboehm7 closed pull request #2240: Improve test coverage for rewrite package
URL: https://github.com/apache/systemds/pull/2240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org