You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/16 09:41:18 UTC
[GitHub] [iotdb] HTHou commented on a change in pull request #5063: [IOTDB-2543] Support le & lt filters in last query
HTHou commented on a change in pull request #5063:
URL: https://github.com/apache/iotdb/pull/5063#discussion_r807729663
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/physical/crud/LastQueryPlan.java
##########
@@ -80,16 +77,12 @@ public void setExpression(IExpression expression) throws QueryProcessException {
if (isValidExpression(expression)) {
super.setExpression(expression);
} else {
- throw new QueryProcessException("Only '>' and '>=' are supported in LAST query");
+ throw new QueryProcessException("Only time filters are supported in LAST query");
}
}
// Only > and >= are supported in time filter
private boolean isValidExpression(IExpression expression) {
- if (expression instanceof GlobalTimeExpression) {
- Filter filter = ((GlobalTimeExpression) expression).getFilter();
- return filter instanceof TimeGtEq || filter instanceof TimeGt;
- }
- return false;
+ return expression instanceof GlobalTimeExpression;
Review comment:
Only time filters are supported in LAST query.
What about other time filter like `TimeEq`, `TimeNotEq` or `TimeIn` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org