You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/03/02 20:16:14 UTC
[GitHub] [hadoop] invincible-akshay opened a new pull request #1871: Update
HdfsDesign.md
invincible-akshay opened a new pull request #1871: Update HdfsDesign.md
URL: https://github.com/apache/hadoop/pull/1871
Proposed change is in 2nd last sentence of the affected paragraph.
Considering the statement segmented in 3 parts by the commas:
1. the first part talks about "one thirds of replicas";
2. the second part talks about "two thirds of replicas"
3. the third part talking about "the other third" is leading to ambiguity when one thirds and two thirds have already accounted for the whole.
Possible solution is to either get rid of the third part or rephrase entire sentence to capture the overall essence of the sentence.
Please suggest.
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] invincible-akshay commented on issue #1871: Hadoop-16899.
Update HdfsDesign.md to reduce ambiguity.
Posted by GitBox <gi...@apache.org>.
invincible-akshay commented on issue #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-593747194
Hi @aajisaka , thank you for your feedback. I agree with you, talk about fractions made me think about multiple blocks of file. I will replace the sentence with the one you suggested, it will make it clear.
I am happy to include the 2nd recommended update as well.
I will update and raise the PR again.
Or is it appropriate to update the code in same branch and let the PR get updated automatically? This is my first time so not very sure about the conventions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on issue #1871: Hadoop-16899. Update
HdfsDesign.md to reduce ambiguity.
Posted by GitBox <gi...@apache.org>.
aajisaka commented on issue #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-593753554
Thanks.
> Or is it appropriate to update the code in same branch and let the PR get updated automatically? This is my first time so not very sure about the conventions.
You can add commits in the same branch and let the PR get updated automatically :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] invincible-akshay commented on issue #1871: Hadoop-16899.
Update HdfsDesign.md to reduce ambiguity.
Posted by GitBox <gi...@apache.org>.
invincible-akshay commented on issue #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-593759072
Should we also update the following:
> With this policy, the replicas of a file do not evenly distribute across the racks.
- file -> block
And for the previous discussion I'm considering the statement as follows:
> Two replicas are on different nodes of one rack and the remaining replica is on a node of one of the other racks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] invincible-akshay commented on issue #1871: Update
HdfsDesign.md
Posted by GitBox <gi...@apache.org>.
invincible-akshay commented on issue #1871: Update HdfsDesign.md
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-593597372
Closing because the procedure to raise a JIRA before pull request wasn't followed, will raise again with right steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1871: Hadoop-16899.
Update HdfsDesign.md to reduce ambiguity.
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-593644340
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 26s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 20m 57s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 13s | trunk passed |
| +1 :green_heart: | shadedclient | 37m 36s | branch has no errors when building and testing our client artifacts. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 8s | the patch passed |
| +1 :green_heart: | mvnsite | 1m 8s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 15m 3s | patch has no errors when building and testing our client artifacts. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 28s | The patch does not generate ASF License warnings. |
| | | 57m 28s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1871/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1871 |
| Optional Tests | dupname asflicense mvnsite markdownlint |
| uname | Linux 01eccb3eecf9 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / edc2e9d |
| Max. process+thread count | 344 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1871/1/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka merged pull request #1871: Hadoop-16899. Update
HdfsDesign.md to reduce ambiguity.
Posted by GitBox <gi...@apache.org>.
aajisaka merged pull request #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.
URL: https://github.com/apache/hadoop/pull/1871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] aajisaka commented on issue #1871: Hadoop-16899. Update
HdfsDesign.md to reduce ambiguity.
Posted by GitBox <gi...@apache.org>.
aajisaka commented on issue #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-593742741
Thank you for your contribution.
The sentence seems still ambiguous to me
> One third of replicas are on one node, two thirds of replicas are on one rack.
-> Two replicas are on one rack, and the remaining replica is on one of the other racks.
- The replication factor is 3 in this sentence, so 'one' seems clearer than 'one third'.
- This sentence should tell that a replica is on a rack (instead of node) and the other two replicas are on one of 'the other' racks.
The following sentence is not directly related to your PR, however, it can be fixed at the same time.
> However, it does reduce the aggregate network bandwidth used when reading data since a block is placed in only two unique racks rather than three. With this policy, the replicas of a file do not evenly distribute across the racks.
* it does reduce -> it does not reduce
If a block is placed in three unique racks, the probability of rack-local read will increase and the network bandwidth will be reduced when reading the data. Therefore I think 'does' should be changed to 'does not'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on issue #1871: Hadoop-16899.
Update HdfsDesign.md to reduce ambiguity.
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on issue #1871: Hadoop-16899. Update HdfsDesign.md to reduce ambiguity.
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-594079977
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 37s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +0 :ok: | markdownlint | 0m 0s | markdownlint was not available. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 19m 14s | trunk passed |
| +1 :green_heart: | mvnsite | 1m 14s | trunk passed |
| +1 :green_heart: | shadedclient | 34m 24s | branch has no errors when building and testing our client artifacts. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 6s | the patch passed |
| +1 :green_heart: | mvnsite | 1m 7s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 13m 45s | patch has no errors when building and testing our client artifacts. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
| | | 53m 15s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1871/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/1871 |
| Optional Tests | dupname asflicense mvnsite markdownlint |
| uname | Linux cdbaa9a58979 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / c0d0842 |
| Max. process+thread count | 414 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs |
| Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1871/2/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] invincible-akshay closed pull request #1871: Update
HdfsDesign.md
Posted by GitBox <gi...@apache.org>.
invincible-akshay closed pull request #1871: Update HdfsDesign.md
URL: https://github.com/apache/hadoop/pull/1871
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] invincible-akshay commented on issue #1871: Update
HdfsDesign.md
Posted by GitBox <gi...@apache.org>.
invincible-akshay commented on issue #1871: Update HdfsDesign.md
URL: https://github.com/apache/hadoop/pull/1871#issuecomment-593617851
Re-opened on creating JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] invincible-akshay opened a new pull request #1871: Update
HdfsDesign.md
Posted by GitBox <gi...@apache.org>.
invincible-akshay opened a new pull request #1871: Update HdfsDesign.md
URL: https://github.com/apache/hadoop/pull/1871
Proposed change is in 2nd last sentence of the affected paragraph.
Considering the statement segmented in 3 parts by the commas:
1. the first part talks about "one thirds of replicas";
2. the second part talks about "two thirds of replicas"
3. the third part talking about "the other third" is leading to ambiguity when one thirds and two thirds have already accounted for the whole.
Possible solution is to either get rid of the third part or rephrase entire sentence to capture the overall essence of the sentence.
Please suggest.
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org