[GitHub] nswamy commented on a change in pull request #11239: [MXNET-319] Javadoc fix

[GitBox <gi...@apache.org>]

nswamy commented on a change in pull request #11239: [MXNET-319] Javadoc fix
URL: https://github.com/apache/incubator-mxnet/pull/11239#discussion_r194842540
 
 

 ##########
 File path: scala-package/native/osx-x86_64-cpu/pom.xml
 ##########
 @@ -67,7 +67,7 @@
             <linkerMiddleOption>-Wl,-x</linkerMiddleOption>
             <linkerMiddleOption>${lddeps}</linkerMiddleOption>
             <linkerMiddleOption>-force_load ../../../lib/libmxnet.a</linkerMiddleOption>
-            <linkerMiddleOption>-force_load ../../../3rdparty/tvm/nnvm/lib/libnnvm.a</linkerMiddleOption>
+            <linkerMiddleOption>-force_load ../../../3rdparty/nnvm/lib/libnnvm.a</linkerMiddleOption>
 
 Review comment:
   Why is this required? `${lddeps}` should already have these ? see how it is setup
   https://github.com/apache/incubator-mxnet/blob/master/Makefile#L386
   https://github.com/apache/incubator-mxnet/blob/master/Makefile#L581

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services