You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org> on 2023/11/08 12:35:48 UTC
[PR] [refactor](opentelemetry) Remove opentelemetry [doris]
zhiqiang-hhhh opened a new pull request, #26605:
URL: https://github.com/apache/doris/pull/26605
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1801807103
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803132021
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 7ead7aae8b6d27e1e1f4831ccacde876a107de88, data reload: false
run tpch-sf100 query with default conf and session variables
q1 5317 5008 5039 5008
q2 381 244 230 230
q3 2046 2005 2071 2005
q4 1466 1430 1433 1430
q5 4117 4118 4099 4099
q6 249 130 133 130
q7 2084 1605 1613 1605
q8 2758 2706 2712 2706
q9 10419 10279 10225 10225
q10 3494 3597 3551 3551
q11 365 255 263 255
q12 447 295 307 295
q13 4491 4111 4118 4111
q14 320 292 296 292
q15 632 561 556 556
q16 693 618 600 600
q17 1137 1087 1084 1084
q18 7802 7404 7480 7404
q19 1680 1668 1671 1668
q20 589 358 352 352
q21 4910 4545 4521 4521
q22 549 450 424 424
Total cold run time: 55946 ms
Total hot run time: 52551 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4973 5017 5027 5017
q2 336 247 237 237
q3 3995 4017 3995 3995
q4 2798 2780 2774 2774
q5 6445 6371 6461 6371
q6 237 129 126 126
q7 3148 2738 2748 2738
q8 4756 4693 4667 4667
q9 17817 17625 17508 17508
q10 4085 4157 4159 4157
q11 773 665 642 642
q12 994 827 800 800
q13 4294 3867 3971 3867
q14 372 346 342 342
q15 601 547 555 547
q16 762 698 728 698
q17 3944 3942 3944 3942
q18 9481 9226 9318 9226
q19 1748 1738 1778 1738
q20 2393 2042 2032 2032
q21 8870 8763 8750 8750
q22 943 852 916 852
Total cold run time: 83765 ms
Total hot run time: 81026 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803305301
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1801927809
TeamCity be ut coverage result:
Function Coverage: 36.71% (8385/22844)
Line Coverage: 29.22% (68006/232702)
Region Coverage: 27.88% (35193/126211)
Branch Coverage: 24.71% (18006/72872)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a18fe49c1887629d3251612091e9d978338e8289_a18fe49c1887629d3251612091e9d978338e8289/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803124076
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.46 seconds
stream load tsv: 571 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 68 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 35 seconds loaded 861443392 Bytes, about 23 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17162657973 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803081226
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803095690
TeamCity be ut coverage result:
Function Coverage: 36.74% (8396/22851)
Line Coverage: 29.24% (68065/232756)
Region Coverage: 27.90% (35219/126232)
Branch Coverage: 24.71% (18005/72878)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7ead7aae8b6d27e1e1f4831ccacde876a107de88_7ead7aae8b6d27e1e1f4831ccacde876a107de88/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #26605:
URL: https://github.com/apache/doris/pull/26605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1801832109
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "zhiqiang-hhhh (via GitHub)" <gi...@apache.org>.
zhiqiang-hhhh commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803049365
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #26605:
URL: https://github.com/apache/doris/pull/26605#discussion_r1386579869
##########
be/src/runtime/load_stream.h:
##########
@@ -18,15 +18,14 @@
#pragma once
#include <gen_cpp/internal_service.pb.h>
Review Comment:
warning: 'gen_cpp/internal_service.pb.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/internal_service.pb.h>
^
```
##########
be/src/service/internal_service.cpp:
##########
@@ -337,13 +333,11 @@ void PInternalServiceImpl::exec_plan_fragment_prepare(google::protobuf::RpcContr
}
}
-void PInternalServiceImpl::exec_plan_fragment_start(google::protobuf::RpcController* controller,
+void PInternalServiceImpl::exec_plan_fragment_start(google::protobuf::RpcController* /*controller*/,
Review Comment:
warning: method 'exec_plan_fragment_start' can be made static [readability-convert-member-functions-to-static]
```suggestion
static void PInternalServiceImpl::exec_plan_fragment_start(google::protobuf::RpcController* /*controller*/,
```
##########
be/src/service/internal_service.cpp:
##########
@@ -556,13 +550,11 @@
}
}
-void PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController* controller,
+void PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController* /*controller*/,
Review Comment:
warning: method 'cancel_plan_fragment' can be made static [readability-convert-member-functions-to-static]
```suggestion
static void PInternalServiceImpl::cancel_plan_fragment(google::protobuf::RpcController* /*controller*/,
```
##########
be/src/runtime/memory/jemalloc_hook.cpp:
##########
@@ -19,7 +19,6 @@
#include <stdint.h>
#include <stdlib.h>
-// IWYU pragma: no_include <opentelemetry/common/threadlocal.h>
#include "common/compiler_util.h" // IWYU pragma: keep
#include "jemalloc/jemalloc.h"
Review Comment:
warning: 'jemalloc/jemalloc.h' file not found [clang-diagnostic-error]
```cpp
#include "jemalloc/jemalloc.h"
^
```
##########
be/src/runtime/load_stream_mgr.h:
##########
@@ -18,15 +18,14 @@
#pragma once
#include <gen_cpp/internal_service.pb.h>
Review Comment:
warning: 'gen_cpp/internal_service.pb.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/internal_service.pb.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1801968412
TeamCity be ut coverage result:
Function Coverage: 36.70% (8384/22844)
Line Coverage: 29.22% (67999/232702)
Region Coverage: 27.87% (35177/126211)
Branch Coverage: 24.70% (17999/72872)
Coverage Report: http://coverage.selectdb-in.cc/coverage/15171fa80e11367f6faa1420c9a114947ecefa9f_15171fa80e11367f6faa1420c9a114947ecefa9f/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803095104
TeamCity be ut coverage result:
Function Coverage: 36.74% (8396/22851)
Line Coverage: 29.24% (68063/232756)
Region Coverage: 27.90% (35216/126232)
Branch Coverage: 24.71% (18009/72878)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0045725923417b32032903fe9fd128036647839b_0045725923417b32032903fe9fd128036647839b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803305246
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Refactor](opentelemetry) Remove opentelemetry [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #26605:
URL: https://github.com/apache/doris/pull/26605#issuecomment-1803124375
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.48 seconds
stream load tsv: 572 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 34 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17162661804 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org