You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2009/04/28 17:01:31 UTC
[jira] Created: (FELIX-1066) Assume a default type/classified
(xml/features) on the features addUrl/removeUrl commands
Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands
-----------------------------------------------------------------------------------------
Key: FELIX-1066
URL: https://issues.apache.org/jira/browse/FELIX-1066
Project: Felix
Issue Type: Improvement
Components: Karaf
Reporter: Guillaume Nodet
When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do:
{code}
features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
{code}
We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1066) Assume a default type/classified
(xml/features) on the features addUrl/removeUrl commands
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moloney updated FELIX-1066:
-------------------------------
Attachment: (was: FELIX-1066-OptionalMavenUrlComponents.patch)
> Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-1066
> URL: https://issues.apache.org/jira/browse/FELIX-1066
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Guillaume Nodet
>
> When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-1066) Assume a default type/classified
(xml/features) on the features addUrl/removeUrl commands
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet closed FELIX-1066.
----------------------------------
Resolution: Won't Fix
So let's close this issue.
> Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-1066
> URL: https://issues.apache.org/jira/browse/FELIX-1066
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Guillaume Nodet
> Attachments: FELIX-1066-OptionalMavenUrlComponents.patch
>
>
> When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1066) Assume a default type/classified
(xml/features) on the features addUrl/removeUrl commands
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744112#action_12744112 ]
Tim Moloney commented on FELIX-1066:
------------------------------------
True. In fact, that's how my features repo was deployed before this patch, but I thought that I wasn't following convention, so I changed it.
I'm leaning towards "bad idea" personally.
I've been running with the patch for the last couple of days and I've found the following:
- loading the URI when it is missing the version is slower than just typing the version
(note that defaulting the version wasn't part of the original issue)
- it forces people to use the "features" classifier
- if we attempt to load the file without the features modifier, then on failure, attempt with
the features modifier, I believe it will be as slow as omitting the version (I haven't
tested this so I could be wrong)
Overall, it seems to add too much overhead to save a few keystrokes.
> Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-1066
> URL: https://issues.apache.org/jira/browse/FELIX-1066
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Guillaume Nodet
> Attachments: FELIX-1066-OptionalMavenUrlComponents.patch
>
>
> When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1066) Assume a default type/classified
(xml/features) on the features addUrl/removeUrl commands
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moloney updated FELIX-1066:
-------------------------------
Comment: was deleted
(was: FELIX-1066-OptionalMavenUrlComponents.patch make the version, type, and classifier components of the Maven URL optional.
)
> Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-1066
> URL: https://issues.apache.org/jira/browse/FELIX-1066
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Guillaume Nodet
>
> When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1066) Assume a default type/classified
(xml/features) on the features addUrl/removeUrl commands
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12744109#action_12744109 ]
Guillaume Nodet commented on FELIX-1066:
----------------------------------------
I have a problem with this patch. It means if someone has an xml repository deployed with no maven classifier, it won't work.
mvn:foo/bar/1.0/xml
then this patch will automatically add /features to the uri.
I think it would be better to try loading the file using the plain url, and maybe try again with /xml/features or /features appended to the uri.
Or maybe it was a bad idea ...
> Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-1066
> URL: https://issues.apache.org/jira/browse/FELIX-1066
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Guillaume Nodet
> Attachments: FELIX-1066-OptionalMavenUrlComponents.patch
>
>
> When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1066) Assume a default type/classified
(xml/features) on the features addUrl/removeUrl commands
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moloney updated FELIX-1066:
-------------------------------
Attachment: FELIX-1066-OptionalMavenUrlComponents.patch
FELIX-1066-OptionalMavenUrlComponents.patch make the version, type, and classifier components of the Maven URL optional.
> Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-1066
> URL: https://issues.apache.org/jira/browse/FELIX-1066
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Guillaume Nodet
> Attachments: FELIX-1066-OptionalMavenUrlComponents.patch
>
>
> When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-1066) Assume a default type/classified
(xml/features) on the features addUrl/removeUrl commands
Posted by "Tim Moloney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Moloney updated FELIX-1066:
-------------------------------
Attachment: FELIX-1066-OptionalMavenUrlComponents.patch
FELIX-1066-OptionalMavenUrlComponents.patch make the version, type, and classifier components of the Maven URL optional.
> Assume a default type/classified (xml/features) on the features addUrl/removeUrl commands
> -----------------------------------------------------------------------------------------
>
> Key: FELIX-1066
> URL: https://issues.apache.org/jira/browse/FELIX-1066
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Reporter: Guillaume Nodet
> Attachments: FELIX-1066-OptionalMavenUrlComponents.patch
>
>
> When doing an features/addUrl, you always have to specify the type (xml) and classifier (features). How about making that the default, so people can just do:
> {code}
> features/addUrl mvn:org.apache.servicemix.features/apache-servicemix/4.0.0
> {code}
> We can always fail-back to type jar if we don't find the xml file to support deploying new feature descriptors through a bundle.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.