You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/03/10 21:30:59 UTC
[GitHub] [calcite] vlsi opened a new pull request #2368: Remove row and cost attributes from testQuery17Plan
vlsi opened a new pull request #2368:
URL: https://github.com/apache/calcite/pull/2368
The test is not executed by default (it is slow), it is hard to update
since it is writtend as very long Java string, and the expected output
changes very often.
Removal of the cost attributes should make the test easier to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] julianhyde commented on pull request #2368: Remove row and cost attributes from testQuery17Plan
Posted by GitBox <gi...@apache.org>.
julianhyde commented on pull request #2368:
URL: https://github.com/apache/calcite/pull/2368#issuecomment-796333575
You could change the`checkMaskedResultContains` method to remove the attributes before comparing. That way, if the plan changes shape, you can see why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] vlsi closed pull request #2368: Remove row and cost attributes from testQuery17Plan
Posted by GitBox <gi...@apache.org>.
vlsi closed pull request #2368:
URL: https://github.com/apache/calcite/pull/2368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] vlsi commented on pull request #2368: Remove row and cost attributes from testQuery17Plan
Posted by GitBox <gi...@apache.org>.
vlsi commented on pull request #2368:
URL: https://github.com/apache/calcite/pull/2368#issuecomment-798430339
Right you are. It would probably be better to add a matcher (!), not `Consumer<ResultSet>` that would remove cost attributes.
However, the current `CalciteAssert` is tied to `Consumer<ResultSet>`, and I have no time to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org