[jira] [Created] (TAP5-2264) ResponseCompressionAnalyzerImpl ignores 'tapestry.supress-compression' request attribute for assets and modules

["Felix Gonschorek (JIRA)" <ji...@apache.org>]

Felix Gonschorek created TAP5-2264:
--------------------------------------

             Summary: ResponseCompressionAnalyzerImpl ignores 'tapestry.supress-compression' request attribute for assets and modules
                 Key: TAP5-2264
                 URL: https://issues.apache.org/jira/browse/TAP5-2264
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.4
            Reporter: Felix Gonschorek
            Priority: Minor


version: 5.4 alpha29

for pages and component rendering requests tapestry respects the request attribute org.apache.tapestry5.internal.InternalConstants.SUPPRESS_COMPRESSION.

for modules and assets the request attribute is not being checked in org.apache.tapestry5.internal.services.ResponseCompressionAnalyzerImpl.isGZipSupported().

quick fix: provide a service override for ResponseCompressionAnalyzer with a additional check for this.request.getAttribute(InternalConstants.SUPPRESS_COMPRESSION) != null

reason why we need this: android video playback is crashing when sending gzipped java script files / and or other content. so we want to disable gzip compression for android, even when android supports gzip compression in the Accept-Encoding header.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)