[beam] branch master updated: [BEAM-3288] Add suggested fix to error message (#11622)

[bh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

bhulette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new ad0c5ad  [BEAM-3288] Add suggested fix to error message (#11622)
ad0c5ad is described below

commit ad0c5adbb6141ae3dadbb83304c05ed8b44b8d7b
Author: Brian Hulette <bh...@google.com>
AuthorDate: Fri May 8 15:21:25 2020 -0700

    [BEAM-3288] Add suggested fix to error message (#11622)
    
    * Add sugessted fix
    
    * spotbugs
---
 .../src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java    | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java
index b53ca13..62c795a 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java
@@ -169,8 +169,10 @@ public class GroupByKey<K, V>
     if (!triggerIsSafe(windowingStrategy)) {
       throw new IllegalArgumentException(
           String.format(
-              "Unsafe trigger may lose data, see"
-                  + " https://s.apache.org/finishing-triggers-drop-data: %s",
+              "Unsafe trigger '%s' may lose data, did you mean to wrap it in"
+                  + "`Repeatedly.forever(...)`?%nSee "
+                  + "https://s.apache.org/finishing-triggers-drop-data "
+                  + "for details.",
               windowingStrategy.getTrigger()));
     }
   }