[GitHub] [cassandra] michaelsembwever commented on a diff in pull request #2222: CASSANDRA-12937 rebased against trunk

["michaelsembwever (via GitHub)" <gi...@apache.org>]

michaelsembwever commented on code in PR #2222:
URL: https://github.com/apache/cassandra/pull/2222#discussion_r1159513607


##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -94,6 +94,7 @@
 import org.apache.cassandra.locator.InetAddressAndPort;
 import org.apache.cassandra.locator.Replica;
 import org.apache.cassandra.locator.SeedProvider;
+import org.apache.cassandra.schema.CompressionParams;

Review Comment:
   can we please not import schema class into this package.
   
   this was already raised and addressed here: https://github.com/apache/cassandra/pull/2199#discussion_r1139429951



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org