You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/10/26 21:44:58 UTC

[GitHub] incubator-beam pull request #1196: [BEAM-839] Use a Constant TupleTag in Gro...

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1196

    [BEAM-839] Use a Constant TupleTag in GroupAlsoByWindowEvaluator

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This avoids the cost of generating a random ID, which is moderately
    expensive.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam single_main_output_gabw

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1196.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1196
    
----
commit 3fb939258908ddc2dfce03286f64521cf9ef8841
Author: Thomas Groh <tg...@google.com>
Date:   2016-10-26T21:31:41Z

    Use a Constant TupleTag in GroupAlsoByWindowEvaluator
    
    This avoids the cost of generating a random ID, which is moderately
    expensive.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1196: [BEAM-839] Use a Constant TupleTag in Gro...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1196


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---