You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Mike Drob (JIRA)" <ji...@apache.org> on 2018/04/25 16:34:00 UTC

[jira] [Commented] (HBASE-20478) move import checks from hbaseanti to checkstyle

    [ https://issues.apache.org/jira/browse/HBASE-20478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452595#comment-16452595 ] 

Mike Drob commented on HBASE-20478:
-----------------------------------

getting the treemap stuff into our error-prone ruleset was proving to be very difficult (dealing with generics is not intuitive at the compiler level), but the other changes are easy.

> move import checks from hbaseanti to checkstyle
> -----------------------------------------------
>
>                 Key: HBASE-20478
>                 URL: https://issues.apache.org/jira/browse/HBASE-20478
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>         Attachments: HBASE-20478.0.patch, HBASE-20478.1.patch, HBASE-20478.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.2.patch, HBASE-20478.WIP.patch
>
>
> came up in discussion on HBASE-20332. our check of "don't do this" things in the codebase doesn't log the specifics of complaints anywhere, which forces those who want to follow up to reverse engineer the check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)