You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bertrand Delacretaz (Jira)" <ji...@apache.org> on 2019/11/01 10:00:00 UTC
[jira] [Resolved] (SLING-8740) The repoinit IT is flaky
[ https://issues.apache.org/jira/browse/SLING-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Delacretaz resolved SLING-8740.
----------------------------------------
Resolution: Fixed
I have added a Pax Exam based {{RepositoryInitializerIT}} to bring the test coverage back to what it was with the old {{ProvisioningModelIT}}.
The tests are now stable, ran a number of them successfully at https://builds.apache.org/job/Sling/job/sling-org-apache-sling-jcr-repoinit/job/master/
One unit test failed in one of those runs but it is unrelated, see below, looks like a different issue.
With these changes the tests that were problematic are stable, marking this issue resolved.
I have set the tests to run hourly (via a {{.sling-module.json}} file), will leave that for a few days so we get more data.
The unrelated unit test that failed once in many runs is
{code}
build #96, PrincipalBasedAclTest.globRestriction:292->assertPermission:175
Expecting read for path /tmp_11e74abc-dc7c-4d7d-9cdc-264f4a3fb352/testxyz_11e74abc-dc7c-4d7d-9cdc-264f4a3fb352
to be denied expected:<false> but was:<true>
{code}
> The repoinit IT is flaky
> ------------------------
>
> Key: SLING-8740
> URL: https://issues.apache.org/jira/browse/SLING-8740
> Project: Sling
> Issue Type: Bug
> Components: Repoinit
> Affects Versions: Repoinit JCR 1.1.14
> Reporter: Radu Cotescu
> Assignee: Bertrand Delacretaz
> Priority: Major
> Fix For: Repoinit JCR 1.1.16
>
>
> The repoinit IT are flaky, consistently failing on Jenkins [0][1][2][3][4] but only occasionally on my machine:
> {noformat}
> Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 45.993 sec <<< FAILURE! - in org.apache.sling.jcr.repoinit.it.ProvisioningModelIT
> namespaceAndCndRegistered(org.apache.sling.jcr.repoinit.it.ProvisioningModelIT) Time elapsed: 14.793 sec <<< ERROR!
> java.lang.IllegalStateException: unable to get a service reference, class=org.apache.sling.jcr.api.SlingRepository, filter='null'
> at org.apache.sling.junit.rules.ServerSideTeleporter.getService(ServerSideTeleporter.java:83)
> at org.apache.sling.junit.rules.TeleporterRule.getService(TeleporterRule.java:136)
> at org.apache.sling.jcr.repoinit.it.ProvisioningModelIT.setup(ProvisioningModelIT.java:48)
> userDisabled(org.apache.sling.jcr.repoinit.it.ProvisioningModelIT) Time elapsed: 10.826 sec <<< ERROR!
> java.lang.IllegalStateException: unable to get a service reference, class=org.apache.sling.jcr.api.SlingRepository, filter='null'
> at org.apache.sling.junit.rules.ServerSideTeleporter.getService(ServerSideTeleporter.java:83)
> at org.apache.sling.junit.rules.TeleporterRule.getService(TeleporterRule.java:136)
> at org.apache.sling.jcr.repoinit.it.ProvisioningModelIT.setup(ProvisioningModelIT.java:48)
> usersCreated(org.apache.sling.jcr.repoinit.it.ProvisioningModelIT) Time elapsed: 10.156 sec <<< ERROR!
> java.lang.IllegalStateException: unable to get a service reference, class=org.apache.sling.jcr.api.SlingRepository, filter='null'
> at org.apache.sling.junit.rules.ServerSideTeleporter.getService(ServerSideTeleporter.java:83)
> at org.apache.sling.junit.rules.TeleporterRule.getService(TeleporterRule.java:136)
> at org.apache.sling.jcr.repoinit.it.ProvisioningModelIT.setup(ProvisioningModelIT.java:48)
> userAclSet(org.apache.sling.jcr.repoinit.it.ProvisioningModelIT) Time elapsed: 10.166 sec <<< ERROR!
> java.lang.IllegalStateException: unable to get a service reference, class=org.apache.sling.jcr.api.SlingRepository, filter='null'
> at org.apache.sling.junit.rules.ServerSideTeleporter.getService(ServerSideTeleporter.java:83)
> at org.apache.sling.junit.rules.TeleporterRule.getService(TeleporterRule.java:136)
> at org.apache.sling.jcr.repoinit.it.ProvisioningModelIT.setup(ProvisioningModelIT.java:48)
> Running org.apache.sling.jcr.repoinit.it.RepoInitTextIT
> Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 30.593 sec <<< FAILURE! - in org.apache.sling.jcr.repoinit.it.RepoInitTextIT
> anotherUserAcl(org.apache.sling.jcr.repoinit.it.RepoInitTextIT) Time elapsed: 10.198 sec <<< ERROR!
> java.lang.IllegalStateException: unable to get a service reference, class=org.apache.sling.jcr.api.SlingRepository, filter='null'
> at org.apache.sling.junit.rules.ServerSideTeleporter.getService(ServerSideTeleporter.java:83)
> at org.apache.sling.junit.rules.TeleporterRule.getService(TeleporterRule.java:136)
> at org.apache.sling.jcr.repoinit.it.RepoInitTextIT.setup(RepoInitTextIT.java:55)
> fredWilmaAcl(org.apache.sling.jcr.repoinit.it.RepoInitTextIT) Time elapsed: 10.212 sec <<< ERROR!
> java.lang.IllegalStateException: unable to get a service reference, class=org.apache.sling.jcr.api.SlingRepository, filter='null'
> at org.apache.sling.junit.rules.ServerSideTeleporter.getService(ServerSideTeleporter.java:83)
> at org.apache.sling.junit.rules.TeleporterRule.getService(TeleporterRule.java:136)
> at org.apache.sling.jcr.repoinit.it.RepoInitTextIT.setup(RepoInitTextIT.java:55)
> serviceUserCreated(org.apache.sling.jcr.repoinit.it.RepoInitTextIT) Time elapsed: 10.182 sec <<< ERROR!
> java.lang.IllegalStateException: unable to get a service reference, class=org.apache.sling.jcr.api.SlingRepository, filter='null'
> at org.apache.sling.junit.rules.ServerSideTeleporter.getService(ServerSideTeleporter.java:83)
> at org.apache.sling.junit.rules.TeleporterRule.getService(TeleporterRule.java:136)
> at org.apache.sling.jcr.repoinit.it.RepoInitTextIT.setup(RepoInitTextIT.java:55)
> Results :
> Tests in error:
> ProvisioningModelIT.setup:48 » IllegalState unable to get a service reference,...
> ProvisioningModelIT.setup:48 » IllegalState unable to get a service reference,...
> ProvisioningModelIT.setup:48 » IllegalState unable to get a service reference,...
> ProvisioningModelIT.setup:48 » IllegalState unable to get a service reference,...
> RepoInitTextIT.setup:55 » IllegalState unable to get a service reference, clas...
> RepoInitTextIT.setup:55 » IllegalState unable to get a service reference, clas...
> RepoInitTextIT.setup:55 » IllegalState unable to get a service reference, clas...
> Tests run: 7, Failures: 0, Errors: 7, Skipped: 0
> {noformat}
> [0] - https://builds.apache.org/job/Sling/job/sling-org-apache-sling-jcr-repoinit/job/master/67/
> [1] - https://builds.apache.org/job/Sling/job/sling-org-apache-sling-jcr-repoinit/job/master/68/
> [2] - https://builds.apache.org/job/Sling/job/sling-org-apache-sling-jcr-repoinit/job/master/69/
> [3] - https://builds.apache.org/job/Sling/job/sling-org-apache-sling-jcr-repoinit/job/master/74/
> [4] - https://builds.apache.org/job/Sling/job/sling-org-apache-sling-jcr-repoinit/job/master/75/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)