[GitHub] [spark] seanli-rallyhealth commented on a change in pull request #26870: [SPARK-30137][CORE] Support delete file feature in spark

[GitBox <gi...@apache.org>]

seanli-rallyhealth commented on a change in pull request #26870: [SPARK-30137][CORE] Support delete file feature in spark
URL: https://github.com/apache/spark/pull/26870#discussion_r358528810
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/rpc/RpcEnv.scala
 ##########
 @@ -166,6 +166,11 @@ private[spark] trait RpcEnvFileServer {
    */
   def addFile(file: File): String
 
+  /**
+   * Deletes the files from this RpcEnv, so that it need not to hold any reference for this
 
 Review comment:
   "Deletes a file" or "Deletes the files"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org