[GitHub] [hbase] bbeaudreault edited a comment on pull request #4304: HBASE-26909 Make hbase-shaded-mapreduce include hbase-shaded-client-byo-hadoop as a dependency

[GitBox <gi...@apache.org>]

bbeaudreault edited a comment on pull request #4304:
URL: https://github.com/apache/hbase/pull/4304#issuecomment-1085876723


   > Thanks! I just checked and actually we do have these checks already. And they actually are protecting us already, i.e. it's what clued me into this issue: https://github.com/apache/hbase/pull/4304#discussion_r839800459.
   
   Actually I just realized that while do have enforce-banned-dependencies execution, it is currently set to be skipped. I tried enabling it and it resulted in a massive number of errors. I think due to the same oddity I noticed with reactor builds above, where for some reason the dependencies that were included in a shaded jar are still counted as transitive dependencies within the reactor.
   
   I'm about to push a change which adds per-package smoke tests to our invariants checks. In order to accomplish this I needed to be able to more granularly target each artifact beyond the existing `--allow-hadoop` argument. As such I refactored things and was able to eliminate `hbase-shaded-with-hadoop-check-invariants`. Now the one `hbase-shaded-check-invariants` can handle all of our artifact types.
   
   Afterwards I'm going to give a brief look at whether we can un-skip the enforcer. But no promises there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org