You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by vi...@apache.org on 2021/08/09 20:54:52 UTC

[superset] 05/11: fix: Remove grey bar for TableElement component when `metadata` is empty (#16054)

This is an automated email from the ASF dual-hosted git repository.

villebro pushed a commit to branch 1.3
in repository https://gitbox.apache.org/repos/asf/superset.git

commit caa460aa25cd1492fed99a46434c05cfbb0687f3
Author: Hugh A. Miles II <hu...@gmail.com>
AuthorDate: Wed Aug 4 17:07:20 2021 -0400

    fix: Remove grey bar for TableElement component when `metadata` is empty (#16054)
    
    * create serialize json function
    
    * remove grey space with no metadata
    
    * remove console log
    
    (cherry picked from commit 11a2d4dfdd42bed78c913d0b2b1563e077425acf)
---
 superset-frontend/src/SqlLab/components/TableElement.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/src/SqlLab/components/TableElement.tsx b/superset-frontend/src/SqlLab/components/TableElement.tsx
index 775c925..d64ce21 100644
--- a/superset-frontend/src/SqlLab/components/TableElement.tsx
+++ b/superset-frontend/src/SqlLab/components/TableElement.tsx
@@ -133,7 +133,8 @@ const TableElement = ({ table, actions, ...props }: TableElementProps) => {
       ));
     }
 
-    if (!partitions && !metadata) {
+    if (!partitions && (!metadata || !metadata.length)) {
+      // hide partition and metadata card view
       return null;
     }