You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ti...@apache.org on 2023/08/13 14:08:13 UTC

[tika] branch main updated (48e5e72c7 -> c1796feda)

This is an automated email from the ASF dual-hosted git repository.

tilman pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git


    from 48e5e72c7 TIKA-4114: remove unneeded code
     new e726dea09 TIKA-4114: add comment
     new e94139da8 TIKA-4114: add comment TIKA-4064: avoid deprecated method
     new 8438aed24 TIKA-4114: add comment
     new c1796feda TIKA-4114: add comment

The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../src/main/java/org/apache/tika/metadata/AccessPermissions.java    | 2 ++
 .../src/main/java/org/apache/tika/parser/font/TrueTypeParser.java    | 1 +
 .../java/org/apache/tika/renderer/pdf/pdfbox/PDFBoxRenderer.java     | 4 ++--
 .../tika/renderer/pdf/pdfbox/VectorGraphicsOnlyPDFRenderer.java      | 5 +++++
 4 files changed, 10 insertions(+), 2 deletions(-)


[tika] 03/04: TIKA-4114: add comment

Posted by ti...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git

commit 8438aed24ac3bd67ee8c06684544c057f56fc7ac
Author: Tilman Hausherr <ti...@apache.org>
AuthorDate: Sun Aug 13 16:06:08 2023 +0200

    TIKA-4114: add comment
---
 tika-core/src/main/java/org/apache/tika/metadata/AccessPermissions.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tika-core/src/main/java/org/apache/tika/metadata/AccessPermissions.java b/tika-core/src/main/java/org/apache/tika/metadata/AccessPermissions.java
index 5040bd1e6..67067a8ba 100644
--- a/tika-core/src/main/java/org/apache/tika/metadata/AccessPermissions.java
+++ b/tika-core/src/main/java/org/apache/tika/metadata/AccessPermissions.java
@@ -65,6 +65,8 @@ public interface AccessPermissions {
      */
     Property CAN_PRINT = Property.externalText(PREFIX + "can_print");
 
+    //TODO PDFBOX30 replace degraded and DEGRADED with faithful and FAITHFUL
+
     /**
      * Can the user print an image-degraded version of the document.
      */


[tika] 04/04: TIKA-4114: add comment

Posted by ti...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git

commit c1796feda4133e9476edb039ff0055ba1131547d
Author: Tilman Hausherr <ti...@apache.org>
AuthorDate: Sun Aug 13 16:07:58 2023 +0200

    TIKA-4114: add comment
---
 .../tika/renderer/pdf/pdfbox/VectorGraphicsOnlyPDFRenderer.java      | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/renderer/pdf/pdfbox/VectorGraphicsOnlyPDFRenderer.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/renderer/pdf/pdfbox/VectorGraphicsOnlyPDFRenderer.java
index 4dca0241c..d036ac336 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/renderer/pdf/pdfbox/VectorGraphicsOnlyPDFRenderer.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/renderer/pdf/pdfbox/VectorGraphicsOnlyPDFRenderer.java
@@ -46,6 +46,7 @@ public class VectorGraphicsOnlyPDFRenderer extends PDFRenderer {
     /**
      * Returns a new PageDrawer instance, using the given parameters. May be overridden.
      */
+    @Override
     protected PageDrawer createPageDrawer(PageDrawerParameters parameters) throws IOException {
         PageDrawer pageDrawer = new VectorGraphicsOnlyDrawer(parameters);
         pageDrawer.setAnnotationFilter(getAnnotationsFilter());
@@ -102,6 +103,7 @@ public class VectorGraphicsOnlyPDFRenderer extends PDFRenderer {
         public void showTextStrings(COSArray array) throws IOException {
         }
 
+        //TODO PDFBOX30 remove exception
         @Override
         protected void applyTextAdjustment(float tx, float ty) throws IOException {
         }
@@ -110,6 +112,7 @@ public class VectorGraphicsOnlyPDFRenderer extends PDFRenderer {
         protected void showText(byte[] string) throws IOException {
         }
 
+        //TODO PDFBOX30 remove
         @Override
         protected void showGlyph(Matrix textRenderingMatrix, PDFont font, int code, String unicode,
                                  Vector displacement) throws IOException {
@@ -120,11 +123,13 @@ public class VectorGraphicsOnlyPDFRenderer extends PDFRenderer {
                                  Vector displacement) throws IOException {
         }
 
+        //TODO PDFBOX30 remove
         @Override
         protected void showFontGlyph(Matrix textRenderingMatrix, PDFont font, int code,
                                      String unicode, Vector displacement) throws IOException {
         }
 
+        //TODO PDFBOX30 remove
         @Override
         protected void showType3Glyph(Matrix textRenderingMatrix, PDType3Font font, int code,
                                       String unicode, Vector displacement) throws IOException {


[tika] 01/04: TIKA-4114: add comment

Posted by ti...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git

commit e726dea092db3cf09ac530f0c5edc8d496e95051
Author: Tilman Hausherr <ti...@apache.org>
AuthorDate: Sun Aug 13 15:41:58 2023 +0200

    TIKA-4114: add comment
---
 .../src/main/java/org/apache/tika/parser/font/TrueTypeParser.java        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-font-module/src/main/java/org/apache/tika/parser/font/TrueTypeParser.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-font-module/src/main/java/org/apache/tika/parser/font/TrueTypeParser.java
index 4bc30caa3..2efadd0fc 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-font-module/src/main/java/org/apache/tika/parser/font/TrueTypeParser.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-font-module/src/main/java/org/apache/tika/parser/font/TrueTypeParser.java
@@ -63,6 +63,7 @@ public class TrueTypeParser extends AbstractParser {
         TrueTypeFont font = null;
         try {
             TTFParser parser = new TTFParser();
+            //TODO PDFBOX30 use new RandomAccessReadBufferedFile and new RandomAccessReadBuffer
             if (tis != null && tis.hasFile()) {
                 font = parser.parse(tis.getFile());
             } else {


[tika] 02/04: TIKA-4114: add comment TIKA-4064: avoid deprecated method

Posted by ti...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tika.git

commit e94139da85f743f0b8e0099ca463fd58dd46e49d
Author: Tilman Hausherr <ti...@apache.org>
AuthorDate: Sun Aug 13 16:04:29 2023 +0200

    TIKA-4114: add comment
    TIKA-4064: avoid deprecated method
---
 .../main/java/org/apache/tika/renderer/pdf/pdfbox/PDFBoxRenderer.java | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/renderer/pdf/pdfbox/PDFBoxRenderer.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/renderer/pdf/pdfbox/PDFBoxRenderer.java
index 3f146ab15..cea91fcc2 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/renderer/pdf/pdfbox/PDFBoxRenderer.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-pdf-module/src/main/java/org/apache/tika/renderer/pdf/pdfbox/PDFBoxRenderer.java
@@ -26,7 +26,6 @@ import java.util.Collections;
 import java.util.Map;
 import java.util.Set;
 
-import org.apache.commons.io.IOExceptionWithCause;
 import org.apache.pdfbox.pdmodel.PDDocument;
 import org.apache.pdfbox.rendering.ImageType;
 import org.apache.pdfbox.rendering.PDFRenderer;
@@ -100,6 +99,7 @@ public class PDFBoxRenderer implements PDDocumentRenderer, Initializable {
         if (tis.getOpenContainer() != null) {
             pdDocument = (PDDocument) tis.getOpenContainer();
         } else {
+            //TODO PDFBOX30 use Loader.loadPDF(new RandomAccessReadBuffer(is))
             pdDocument = PDDocument.load(is);
             mustClose = true;
         }
@@ -184,7 +184,7 @@ public class PDFBoxRenderer implements PDDocumentRenderer, Initializable {
             } catch (IOException ex) {
                 LOG.warn("couldn't delete " + tmpFile, ex);
             }
-            throw new IOExceptionWithCause(e);
+            throw new IOException(e);
         }
         return new RenderResult(RenderResult.STATUS.SUCCESS, id, tmpFile, metadata);
     }