You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/13 23:10:03 UTC

[GitHub] mbaijal opened a new pull request #12556: Python dockerfiles built on pip binaries and build/release script

mbaijal opened a new pull request #12556: Python dockerfiles built on pip binaries and build/release script
URL: https://github.com/apache/incubator-mxnet/pull/12556
 
 
   ## Description ##
   @bhavinthaker @gautamkmr 
   This PR adds new dockerfiles for Python that are currently being used to release docker images to dockerhub after each MXNet Release. 
   These dockerfiles are built on the MXNet pip binaries instead of 'build from source' as in the existing dockerfiles. This makes the docker files easier to build and keeps the docker & pip binaries consistent. 
   Also, there were performance issues with the existing docker images and this should resolve that (though I have not verified this).
   
   I have also added a script that can be used to build all 6 different images, run 3 sanity tests and upload them to dockerhub (credentials need to be provided) with one command. 
   
   Please refer to the README added for more details. 
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] 4 dockerfiles to build MXNet python for the latest released version. 
   - [ ] Script to automate build, test and release of docker images to dockerhub.
   - [ ] A test script that makes sure that the installed version of mxnet matches the requested version. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services