You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/02/03 22:58:56 UTC
[Impala-ASF-CR] [DOCS] Genericize HBase page
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5900
Change subject: [DOCS] Genericize HBase page
......................................................................
[DOCS] Genericize HBase page
2x links that point to archive.cloudera.com mirror of HBase
docs, point to Apache HBase doc site instead.
Remove a little Cloudera-specific verbiage, esp. in banners of
hive / impala-shell output.
Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_hbase.xml
2 files changed, 15 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/5900/1
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Genericize HBase page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Genericize HBase page
......................................................................
Patch Set 1: Code-Review+2
This will pave the way for a big link-genericizing CR, concentrated in that impala_keydefs.ditamap file.
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize HBase page
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Genericize HBase page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5900/1/docs/topics/impala_hbase.xml
File docs/topics/impala_hbase.xml:
Line 94: See <xref href="#hbase_queries"/> for a full example.
John, these links don't work in the HTML. We already tested this yesterday -- it was the because the filename gets added to the id when it's published - id="impala_hbase__hbase_using"
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize HBase page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Genericize HBase page
......................................................................
Patch Set 1:
I'm abandoning the duplicate review https://gerrit.cloudera.org/#/c/5858/1 because the one here is getting better traction. Although 5858 arguably has a better commit message.
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize HBase page
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Genericize HBase page
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5900/1/docs/topics/impala_hbase.xml
File docs/topics/impala_hbase.xml:
Line 94: See <xref href="#hbase_queries"/> for a full example.
> John, these links don't work in the HTML. We already tested this yesterday
Right, but that's out of the scope for this particular change review. In this review I'm only changing those couple of links with the keyref= attributes.
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Genericize HBase page
Posted by "Ambreen Kazi (Code Review)" <ge...@cloudera.org>.
Ambreen Kazi has posted comments on this change.
Change subject: [DOCS] Genericize HBase page
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize HBase page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize HBase page
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/35/
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize HBase page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Genericize HBase page
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Genericize HBase page
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Genericize HBase page
......................................................................
[DOCS] Genericize HBase page
2x links that point to archive.cloudera.com mirror of HBase
docs, point to Apache HBase doc site instead.
Remove a little Cloudera-specific verbiage, esp. in banners of
hive / impala-shell output.
Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Reviewed-on: http://gerrit.cloudera.org:8080/5900
Reviewed-by: Ambreen Kazi <am...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_hbase.xml
2 files changed, 15 insertions(+), 22 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Ambreen Kazi: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5900
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1b832d23be7182d88c99ee169976ad9aeed746b1
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <am...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>