You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/11/18 00:42:16 UTC

[Impala-ASF-CR] IMPALA-10276: thread-safe access to RuntimeProfile::counter map

Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16739

to look at the new patch set (#3).

Change subject: IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_
......................................................................

IMPALA-10276: thread-safe access to RuntimeProfile::counter_map_

The bug was that 'counter_map_' can be mutated concurrent with
total_time_counter() or inactive_timer() being called.

This is fixed by storing a pointer directly to those counters
and bypassing 'counter_map_'. This is then thread-safe and
also has low overhead (adding lock acquisitions might have
some perf impact, since total_time_counter() is called
throughout query execution).

Change-Id: Ic21a13acf9c7c326a27334e61ce3729f1e3cab42
---
M be/src/util/runtime-profile.cc
M be/src/util/runtime-profile.h
2 files changed, 34 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/39/16739/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic21a13acf9c7c326a27334e61ce3729f1e3cab42
Gerrit-Change-Number: 16739
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>