You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Richard Taylor (JIRA)" <ji...@apache.org> on 2007/07/27 02:06:03 UTC

[jira] Created: (ODE-158) Unable to deal with empty "query" element in to-spec

Unable to deal with empty "query" element in to-spec
----------------------------------------------------

                 Key: ODE-158
                 URL: https://issues.apache.org/jira/browse/ODE-158
             Project: ODE
          Issue Type: Improvement
          Components: BPEL Compilation/Parsing
    Affects Versions: 1.1
         Environment: JDK 1.5.0_11
Axis2 Distro
WinXP x64

            Reporter: Richard Taylor
            Priority: Trivial


Note: A patch is attached for this issue.

There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity.   Ode throws an IllegalStateException stating "XPath string and xpath node are both null".  It is arguable whether this is a Eclipse BPEL issue or Ode issue.  I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.   

Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.

To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.

Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor fixes this on their side, this issue will go away.   



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (ODE-158) Unable to deal with empty "query" element in to-spec

Posted by Rich Taylor <bh...@gmail.com>.
No worries on my part.  Only took a minute or two to fix locally. Besides I
learned a little more about @Override haha.

On 7/27/07, Tammo van Lessen (JIRA) <ji...@apache.org> wrote:
>
>
>     [
> https://issues.apache.org/jira/browse/ODE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516031]
>
> Tammo van Lessen commented on ODE-158:
> --------------------------------------
>
> For the side note: sorry about that. I should not trust my IDE that much
> :) - at least for Java 6 it was compiling...
>
> As I was curious why Eclipse did not complain, I found this thing. FYI:
> http://blogs.sun.com/ahe/entry/override
>
> > Unable to deal with empty "query" element in to-spec
> > ----------------------------------------------------
> >
> >                 Key: ODE-158
> >                 URL: https://issues.apache.org/jira/browse/ODE-158
> >             Project: ODE
> >          Issue Type: Improvement
> >          Components: BPEL Compilation/Parsing
> >    Affects Versions: 1.1
> >         Environment: JDK 1.5.0_11
> > Axis2 Distro
> > WinXP x64
> >            Reporter: Richard Taylor
> >            Assignee: Matthieu Riou
> >            Priority: Trivial
> >             Fix For: 1.1
> >
> >         Attachments: update.patch
> >
> >
> > Note: A patch is attached for this issue.
> > There is currently a common case in the Eclipse BPEL editor which
> inserts an empty "query" element in the to-spec of an "Assign" activity.
> Ode throws an IllegalStateException stating "XPath string and xpath node are
> both null".  It is arguable whether this is a Eclipse BPEL issue or Ode
> issue.  I feel this is an issue on the editor side, not Ode, however we
> needed to work around it until the Eclipse BPEL project stops producing
> empty Query elements.
> > Fixing this removes one more hurdle for someone trying to use the
> Eclipse BPEL editor with Ode.
> > To reproduce this, using the latest Eclipse BPEL editor, simply create a
> process and create an Assign activity in which a value is assigned to a
> variable or a message part, but no deeper, i.e. don't specify a query.
> > Again, this is not a critical fix for Ode, it's something we needed in
> order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor
> fixes this on their side, this issue will go away.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

[jira] Updated: (ODE-158) Unable to deal with empty "query" element in to-spec

Posted by "Richard Taylor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Taylor updated ODE-158:
-------------------------------

    Attachment: update.patch

A patch to fix the discussed issue.  Tested in the specified environment.

> Unable to deal with empty "query" element in to-spec
> ----------------------------------------------------
>
>                 Key: ODE-158
>                 URL: https://issues.apache.org/jira/browse/ODE-158
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Compilation/Parsing
>    Affects Versions: 1.1
>         Environment: JDK 1.5.0_11
> Axis2 Distro
> WinXP x64
>            Reporter: Richard Taylor
>            Priority: Trivial
>         Attachments: update.patch
>
>
> Note: A patch is attached for this issue.
> There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity.   Ode throws an IllegalStateException stating "XPath string and xpath node are both null".  It is arguable whether this is a Eclipse BPEL issue or Ode issue.  I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.   
> Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.
> To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.
> Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor fixes this on their side, this issue will go away.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ODE-158) Unable to deal with empty "query" element in to-spec

Posted by "Richard Taylor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ODE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515921 ] 

Richard Taylor commented on ODE-158:
------------------------------------

You're too fast!  Just after submitting the patch I realized that the same
fix applied to another method in the same file.  I have updated the patch
file, sorry about that.

On a side note, as of a few minutes ago it appears there was a bad check in
of DebugBpelEventListener.java.  It had some extra svn tags in it and
wouldn't compile.

I will definitely keep an eye our for other Eclipse BPEL / Ode integration
issues.   Thanks, Rich



> Unable to deal with empty "query" element in to-spec
> ----------------------------------------------------
>
>                 Key: ODE-158
>                 URL: https://issues.apache.org/jira/browse/ODE-158
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Compilation/Parsing
>    Affects Versions: 1.1
>         Environment: JDK 1.5.0_11
> Axis2 Distro
> WinXP x64
>            Reporter: Richard Taylor
>            Assignee: Matthieu Riou
>            Priority: Trivial
>             Fix For: 1.1
>
>         Attachments: update.patch
>
>
> Note: A patch is attached for this issue.
> There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity.   Ode throws an IllegalStateException stating "XPath string and xpath node are both null".  It is arguable whether this is a Eclipse BPEL issue or Ode issue.  I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.   
> Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.
> To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.
> Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor fixes this on their side, this issue will go away.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (ODE-158) Unable to deal with empty "query" element in to-spec

Posted by "Matthieu Riou (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthieu Riou resolved ODE-158.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1
         Assignee: Matthieu Riou

Thanks for the nice looking code :-) It's a reasonable fix and supporting the Eclipse BPEL editor is certainly important. Feel free to share any other "trick" for Eclipse support.

Patch applied.

> Unable to deal with empty "query" element in to-spec
> ----------------------------------------------------
>
>                 Key: ODE-158
>                 URL: https://issues.apache.org/jira/browse/ODE-158
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Compilation/Parsing
>    Affects Versions: 1.1
>         Environment: JDK 1.5.0_11
> Axis2 Distro
> WinXP x64
>            Reporter: Richard Taylor
>            Assignee: Matthieu Riou
>            Priority: Trivial
>             Fix For: 1.1
>
>         Attachments: update.patch
>
>
> Note: A patch is attached for this issue.
> There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity.   Ode throws an IllegalStateException stating "XPath string and xpath node are both null".  It is arguable whether this is a Eclipse BPEL issue or Ode issue.  I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.   
> Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.
> To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.
> Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor fixes this on their side, this issue will go away.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ODE-158) Unable to deal with empty "query" element in to-spec

Posted by "Matthieu Riou (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ODE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515922 ] 

Matthieu Riou commented on ODE-158:
-----------------------------------

He he, I just happened to have my IDE open at the right place and saw your patch :) The second part has been applied as well. 

For the side note, I think I've corrected that today. At least it wasn't building and it now builds for me.

> Unable to deal with empty "query" element in to-spec
> ----------------------------------------------------
>
>                 Key: ODE-158
>                 URL: https://issues.apache.org/jira/browse/ODE-158
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Compilation/Parsing
>    Affects Versions: 1.1
>         Environment: JDK 1.5.0_11
> Axis2 Distro
> WinXP x64
>            Reporter: Richard Taylor
>            Assignee: Matthieu Riou
>            Priority: Trivial
>             Fix For: 1.1
>
>         Attachments: update.patch
>
>
> Note: A patch is attached for this issue.
> There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity.   Ode throws an IllegalStateException stating "XPath string and xpath node are both null".  It is arguable whether this is a Eclipse BPEL issue or Ode issue.  I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.   
> Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.
> To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.
> Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor fixes this on their side, this issue will go away.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ODE-158) Unable to deal with empty "query" element in to-spec

Posted by "Richard Taylor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Taylor updated ODE-158:
-------------------------------

    Attachment: update.patch

Updated patch file

> Unable to deal with empty "query" element in to-spec
> ----------------------------------------------------
>
>                 Key: ODE-158
>                 URL: https://issues.apache.org/jira/browse/ODE-158
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Compilation/Parsing
>    Affects Versions: 1.1
>         Environment: JDK 1.5.0_11
> Axis2 Distro
> WinXP x64
>            Reporter: Richard Taylor
>            Assignee: Matthieu Riou
>            Priority: Trivial
>             Fix For: 1.1
>
>         Attachments: update.patch
>
>
> Note: A patch is attached for this issue.
> There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity.   Ode throws an IllegalStateException stating "XPath string and xpath node are both null".  It is arguable whether this is a Eclipse BPEL issue or Ode issue.  I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.   
> Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.
> To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.
> Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor fixes this on their side, this issue will go away.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ODE-158) Unable to deal with empty "query" element in to-spec

Posted by "Richard Taylor (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ODE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Richard Taylor updated ODE-158:
-------------------------------

    Attachment:     (was: update.patch)

> Unable to deal with empty "query" element in to-spec
> ----------------------------------------------------
>
>                 Key: ODE-158
>                 URL: https://issues.apache.org/jira/browse/ODE-158
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Compilation/Parsing
>    Affects Versions: 1.1
>         Environment: JDK 1.5.0_11
> Axis2 Distro
> WinXP x64
>            Reporter: Richard Taylor
>            Priority: Trivial
>
> Note: A patch is attached for this issue.
> There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity.   Ode throws an IllegalStateException stating "XPath string and xpath node are both null".  It is arguable whether this is a Eclipse BPEL issue or Ode issue.  I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.   
> Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.
> To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.
> Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor fixes this on their side, this issue will go away.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ODE-158) Unable to deal with empty "query" element in to-spec

Posted by "Tammo van Lessen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ODE-158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12516031 ] 

Tammo van Lessen commented on ODE-158:
--------------------------------------

For the side note: sorry about that. I should not trust my IDE that much :) - at least for Java 6 it was compiling...

As I was curious why Eclipse did not complain, I found this thing. FYI: http://blogs.sun.com/ahe/entry/override

> Unable to deal with empty "query" element in to-spec
> ----------------------------------------------------
>
>                 Key: ODE-158
>                 URL: https://issues.apache.org/jira/browse/ODE-158
>             Project: ODE
>          Issue Type: Improvement
>          Components: BPEL Compilation/Parsing
>    Affects Versions: 1.1
>         Environment: JDK 1.5.0_11
> Axis2 Distro
> WinXP x64
>            Reporter: Richard Taylor
>            Assignee: Matthieu Riou
>            Priority: Trivial
>             Fix For: 1.1
>
>         Attachments: update.patch
>
>
> Note: A patch is attached for this issue.
> There is currently a common case in the Eclipse BPEL editor which inserts an empty "query" element in the to-spec of an "Assign" activity.   Ode throws an IllegalStateException stating "XPath string and xpath node are both null".  It is arguable whether this is a Eclipse BPEL issue or Ode issue.  I feel this is an issue on the editor side, not Ode, however we needed to work around it until the Eclipse BPEL project stops producing empty Query elements.   
> Fixing this removes one more hurdle for someone trying to use the Eclipse BPEL editor with Ode.
> To reproduce this, using the latest Eclipse BPEL editor, simply create a process and create an Assign activity in which a value is assigned to a variable or a message part, but no deeper, i.e. don't specify a query.
> Again, this is not a critical fix for Ode, it's something we needed in order to work with the Eclipse BPEL editor and Ode.  If the Eclipse editor fixes this on their side, this issue will go away.   

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.