You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2019/10/04 08:27:20 UTC

[GitHub] [wicket] martin-g commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM

martin-g commented on a change in pull request #386: WICKET-6531 Crash in Unsafe.getObject when running on the J9 VM
URL: https://github.com/apache/wicket/pull/386#discussion_r331391339
 
 

 ##########
 File path: wicket-core/src/main/java/org/apache/wicket/core/util/objects/checker/CheckingObjectOutputStream.java
 ##########
 @@ -235,6 +235,9 @@ public String toString()
 	{
 		try
 		{
+
+			available = "Oracle Corporation".equals(System.getProperty("java.vm.vendor")); //WICKET-6531
 
 Review comment:
   I am not sure this is a good solution.
   
   ```
   $ jshell                                                                                                                                                                             qa  
   |  Welcome to JShell -- Version 11.0.4
   |  For an introduction type: /help intro
   
   jshell> System.getProperty("java.vm.vendor")
   $1 ==> "Ubuntu"
   
   jshell> ⏎                             
   ```
   
   I think you meant `java.specification.vendor` ?! 
   
   ```
   System.getProperty("java.specification.vendor")
   $2 ==> "Oracle Corporation"
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services