You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Felix Lee <fe...@gmail.com> on 2012/05/23 04:19:21 UTC

Review Request: Update Caja integration

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5202/
-----------------------------------------------------------

Review request for shindig and Jasvir Nagra.


Summary
-------

Shindig's Caja integration is using a year-old version of Caja, and doesn't really work because of bad interaction with Closure compiler.

This patch updates Shindig to use a recent version of Caja.

With this patch, the SocialActivitiesWorld demo works with or without Caja enabled.


This addresses bug SHINDIG-1783.
    https://issues.apache.org/jira/browse/SHINDIG-1783


Diffs
-----

  /trunk/features/src/main/javascript/features/caja-debug/feature.xml 1341682 
  /trunk/features/src/main/javascript/features/caja-guest-frame/feature.xml 1341682 
  /trunk/features/src/main/javascript/features/caja-taming-frame/feature.xml 1341682 
  /trunk/features/src/main/javascript/features/caja/caja-debug.xml PRE-CREATION 
  /trunk/features/src/main/javascript/features/caja/es53-guest-frame.opt.xml PRE-CREATION 
  /trunk/features/src/main/javascript/features/caja/es53-guest-frame.xml PRE-CREATION 
  /trunk/features/src/main/javascript/features/caja/es53-taming-frame.opt.xml PRE-CREATION 
  /trunk/features/src/main/javascript/features/caja/es53-taming-frame.xml PRE-CREATION 
  /trunk/features/src/main/javascript/features/caja/feature.xml 1341682 
  /trunk/features/src/main/javascript/features/caja/taming.js 1341682 
  /trunk/features/src/main/javascript/features/core.json/taming.js 1341682 
  /trunk/features/src/main/javascript/features/features.txt 1341682 
  /trunk/features/src/main/javascript/features/gadgets.json.ext/taming.js 1341682 
  /trunk/features/src/main/javascript/features/osapi.base/osapi.js 1341682 
  /trunk/features/src/main/javascript/features/osapi.base/taming.js 1341682 
  /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java 1341682 
  /trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/AllJsFilter.java 1341682 
  /trunk/pom.xml 1341682 

Diff: https://reviews.apache.org/r/5202/diff


Testing
-------


Thanks,

Felix


Re: Review Request: Update Caja integration

Posted by ๏̯͡๏ Jasvir Nagra <ja...@nagras.com>.
Hey Felix,

Given the reviewboard seems to be down currently, can you upload the patch
to codereview?

jas

-- 
Jasvir Nagra



On Tue, May 22, 2012 at 7:19 PM, Felix Lee <fe...@gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5202/
>   Review request for shindig and Jasvir Nagra.
> By Felix Lee.
> Description
>
> Shindig's Caja integration is using a year-old version of Caja, and doesn't really work because of bad interaction with Closure compiler.
>
> This patch updates Shindig to use a recent version of Caja.
>
> With this patch, the SocialActivitiesWorld demo works with or without Caja enabled.
>
>   *Bugs: * SHINDIG-1783<https://issues.apache.org/jira/browse/SHINDIG-1783>
> Diffs
>
>    - /trunk/features/src/main/javascript/features/caja-debug/feature.xml
>    (1341682)
>    - /trunk/features/src/main/javascript/features/caja-guest-frame/feature.xml
>    (1341682)
>    - /trunk/features/src/main/javascript/features/caja-taming-frame/feature.xml
>    (1341682)
>    - /trunk/features/src/main/javascript/features/caja/caja-debug.xml
>    (PRE-CREATION)
>    - /trunk/features/src/main/javascript/features/caja/es53-guest-frame.opt.xml
>    (PRE-CREATION)
>    - /trunk/features/src/main/javascript/features/caja/es53-guest-frame.xml
>    (PRE-CREATION)
>    - /trunk/features/src/main/javascript/features/caja/es53-taming-frame.opt.xml
>    (PRE-CREATION)
>    - /trunk/features/src/main/javascript/features/caja/es53-taming-frame.xml
>    (PRE-CREATION)
>    - /trunk/features/src/main/javascript/features/caja/feature.xml
>    (1341682)
>    - /trunk/features/src/main/javascript/features/caja/taming.js (1341682)
>    - /trunk/features/src/main/javascript/features/core.json/taming.js
>    (1341682)
>    - /trunk/features/src/main/javascript/features/features.txt (1341682)
>    - /trunk/features/src/main/javascript/features/gadgets.json.ext/taming.js
>    (1341682)
>    - /trunk/features/src/main/javascript/features/osapi.base/osapi.js
>    (1341682)
>    - /trunk/features/src/main/javascript/features/osapi.base/taming.js
>    (1341682)
>    - /trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/CajaContentRewriterTest.java
>    (1341682)
>    - /trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/AllJsFilter.java
>    (1341682)
>    - /trunk/pom.xml (1341682)
>
> View Diff <https://reviews.apache.org/r/5202/diff/>
>