[jira] [Commented] (KAFKA-10100) LiveLeaders field in LeaderAndIsrRequest is not used anymore

["Ismael Juma (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125984#comment-17125984 ] 

Ismael Juma commented on KAFKA-10100:
-------------------------------------

I had noticed this too. I was wondering if it's worth doing this given that KIP-500 will change how we propagate metadata. If there's a concrete performance benefit, then we should do it, of course.

> LiveLeaders field in LeaderAndIsrRequest is not used anymore
> ------------------------------------------------------------
>
>                 Key: KAFKA-10100
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10100
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: David Jacot
>            Assignee: David Jacot
>            Priority: Major
>
> We have noticed that the `LiveLeaders` field in the LeaderAndIsrRequest is not used anywhere but still populated by the controller.
> It seems that that field was introduced in AK `0.8.0` and was supposed to be removed in AK `0.8.1`: [https://github.com/apache/kafka/blob/0.8.0/core/src/main/scala/kafka/cluster/Partition.scala#L194.]
> I think that we can safely deprecate the field and stop populating it for all versions > 0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)