You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/01 02:29:55 UTC
[jira] [Commented] (CB-8484) Cordova package support for Android
[ https://issues.apache.org/jira/browse/CB-8484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389757#comment-14389757 ]
ASF GitHub Bot commented on CB-8484:
------------------------------------
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/164#discussion_r27536261
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -402,6 +440,16 @@ function parseOpts(options, resolvedTarget) {
case 'gradleArg':
ret.extraArgs.push(flagValue);
break;
+ case 'keystore':
+ case 'alias':
+ case 'keytorePassword':
+ case 'password':
+ case 'keystoreType':
+ packageArgs[flagName] = flagValue;
+ break;
+ case 'buildConfig':
+ buildConfig = flagValue.replace(/"/g, '');
--- End diff --
Quotes for these reasons are generally interpreted by the shell (cmd.exe), and when we see it here, they should be gone already (and flagValue will have a space in it).
> Cordova package support for Android
> -----------------------------------
>
> Key: CB-8484
> URL: https://issues.apache.org/jira/browse/CB-8484
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: Android
> Affects Versions: 4.0.0
> Reporter: Nikhil Khandelwal
> Assignee: Nikhil Khandelwal
>
> Details of the design here:
> https://docs.google.com/document/d/1tJQ9OoGrrMhZcLI3mg46rGzAfbiQu9PuNBL1auAMGFM/edit#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org