You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/27 08:25:26 UTC

[GitHub] [flink] zhijiangW opened a new pull request #8551: [FLINK-12630][network] Refactor abstract InputGate to general interface

zhijiangW opened a new pull request #8551: [FLINK-12630][network] Refactor abstract InputGate to general interface
URL: https://github.com/apache/flink/pull/8551
 
 
   ## What is the purpose of the change
   
   *`InputGate` is currently defined as an abstract class which implements the logic of checking data availability for subclasses `SingleInputGate` and `UnionInputGate`, but it might bring limits for further extending `InputGate` implementations in shuffle service architecture. So we refactor the `InputGate` as a general interface and define a new isAvailable method for it. The existing implementation of data availability is extracted as a separate class which could still be used for both single and union gates as now. The future new `InputGate` instances from other shuffle services might have different implementations for data availability.*
   
   ## Brief change log
   
     - *Refactor `InputGate` as interface and define `isAvailable` for it.*
     - *Extract the data available implementation as separate class `FutureBasedDataAvailability`*
     - *Extract `InputWithData` as a separate class*
   
   ## Verifying this change
   
   *covered by existing tests.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services