You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/25 07:37:57 UTC

[GitHub] [arrow] thisisnic commented on pull request #10388: ARROW-12729: [R] Fix length method for Table, RecordBatch

thisisnic commented on pull request #10388:
URL: https://github.com/apache/arrow/pull/10388#issuecomment-847628316


   > Oh, actually one small requested change please: both `Table` and `RecordBatch` inherit the virtual class `ArrowTabular`, so whenever we want to define a method for both `Table` and `RecordBatch` and the implementation of it is exactly the same, we should instead define it on `ArrowTabular`. Could you please change this to use that? The tests can stay the same.
   
   Good point, completely missed that, now done!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org