You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/04/13 18:09:53 UTC

[GitHub] flink pull request #5780: [FLINK-8955][tests] Port ClassLoaderITCase to flip...

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5780#discussion_r181466728
  
    --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java ---
    @@ -117,6 +138,7 @@ public TestEnvironment getTestEnvironment() {
     
     	@Override
     	public void before() throws Exception {
    +		miniClusterResourceConfiguration = Preconditions.checkNotNull(miniClusterResourceConfigurationSupplier.get());
    --- End diff --
    
    I think we are mixing concerns by letting the `MiniClusterResource` change its behaviour across multiple tests. I think we should not pass in a configuration supplier which can lazily instantiate a configuration. Instead if you need a different `MiniClusterResource` per test, then the test should instantiate the respective `MiniClusterResource` with the proper configuration.


---