You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/04/06 07:25:01 UTC
Review Request 45804: Added a path to the upgrade test script.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45804/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
In Mesos 0.28.0, the `MESOS_BUILD_DIR` environment variable in the test framework was changed to `MESOS_HELPER_DIR`, and the location of the path was altered. This patch updates the upgrade script to accommodate both environment variables.
Diffs
-----
support/test-upgrade.py 99c8e7656dc2a2f54a309d4a369e73ca2ab2f4dd
Diff: https://reviews.apache.org/r/45804/diff/
Testing
-------
Used `support/test-upgrade.py --prev="/path/to/0.27.2" --next="/path/to/0.28.1-rc2"` to test.
Thanks,
Greg Mann
Re: Review Request 45804: Added a path to the upgrade test script.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45804/#review127298
-----------------------------------------------------------
Ship it!
Let's add a JIRA ticket to description, so that "the next" guy will save some time.
Also, I dream of cross-platform helper functions that will allow us to define things like helper directory once, i.e. being able to call `getTestScriptPath()` from this python helper...
- Alexander Rukletsov
On April 6, 2016, 5:25 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45804/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 5:25 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In Mesos 0.28.0, the `MESOS_BUILD_DIR` environment variable in the test framework was changed to `MESOS_HELPER_DIR`, and the location of the path was altered. This patch updates the upgrade script to accommodate both environment variables.
>
>
> Diffs
> -----
>
> support/test-upgrade.py 99c8e7656dc2a2f54a309d4a369e73ca2ab2f4dd
>
> Diff: https://reviews.apache.org/r/45804/diff/
>
>
> Testing
> -------
>
> Used `support/test-upgrade.py --prev="/path/to/0.27.2" --next="/path/to/0.28.1-rc2"` to test.
>
>
> Thanks,
>
> Greg Mann
>
>