[GitHub] [arrow] felipecrv commented on a diff in pull request #36418: GH-36417: [C++] Add Buffer::data_as, Buffer::mutable_data_as

["felipecrv (via GitHub)" <gi...@apache.org>]

felipecrv commented on code in PR #36418:
URL: https://github.com/apache/arrow/pull/36418#discussion_r1248318459


##########
cpp/src/arrow/array/array_base.h:
##########
@@ -106,7 +106,7 @@ class ARROW_EXPORT Array {
   /// \see GetNullCount
   int64_t ComputeLogicalNullCount() const;
 
-  std::shared_ptr<DataType> type() const { return data_->type; }
+  const std::shared_ptr<DataType>& type() const { return data_->type; }

Review Comment:
   Nice. This always annoyed me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org