You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "wallezhang (via GitHub)" <gi...@apache.org> on 2024/05/29 11:46:46 UTC
[PR] Upgrade flink default version to 1.15 [inlong]
wallezhang opened a new pull request, #10310:
URL: https://github.com/apache/inlong/pull/10310
<!-- Prepare a Pull Request
Change the title of pull request refer to the following example:
[INLONG-XYZ][Component] Title of the pull request
-->
<!-- Specify the issue this pull request going to fix.
The following *XYZ* should be replaced by the actual [GitHub Issue](https://github.com/apache/inlong/issues) number)-->
Fixes #10284
### Motivation
<!--Explain here the context, and why you're making that change. What is the problem you're trying to solve.-->
### Modifications
<!--Describe the modifications you've done.-->
### Verifying this change
*(Please pick either of the following options)*
- [x] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "EMsnap (via GitHub)" <gi...@apache.org>.
EMsnap commented on code in PR #10310:
URL: https://github.com/apache/inlong/pull/10310#discussion_r1630915637
##########
inlong-sort/sort-formats/format-row/format-json-v1.18/src/main/java/org/apache/inlong/sort/formats/json/canal/CanalJsonEnhancedSerializationSchema.java:
##########
@@ -108,6 +108,11 @@ public Object getFieldOrNull(RowData row) {
mapNullKeyMode,
mapNullKeyLiteral,
encodeDecimalAsPlainNumber);
+ try {
+ this.jsonSerializer.open(null);
Review Comment:
open method should move to CanalJsonEnhancedSerializationSchema.open() method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "wallezhang (via GitHub)" <gi...@apache.org>.
wallezhang commented on PR #10310:
URL: https://github.com/apache/inlong/pull/10310#issuecomment-2141557311
> https://github.com/apache/inlong/blob/ca0983fcebf70c68f8e79f341c992b1d2c5970f4/inlong-manager/manager-plugins/base/src/main/resources/flink-sort-plugin.properties#L25
>
> flink version in configuration also need to upgrade
Thanks for your advice. I have modified it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "wallezhang (via GitHub)" <gi...@apache.org>.
wallezhang commented on code in PR #10310:
URL: https://github.com/apache/inlong/pull/10310#discussion_r1634085604
##########
inlong-sort/sort-formats/format-row/format-json-v1.18/src/main/java/org/apache/inlong/sort/formats/json/canal/CanalJsonEnhancedSerializationSchema.java:
##########
@@ -108,6 +108,11 @@ public Object getFieldOrNull(RowData row) {
mapNullKeyMode,
mapNullKeyLiteral,
encodeDecimalAsPlainNumber);
+ try {
+ this.jsonSerializer.open(null);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #10310:
URL: https://github.com/apache/inlong/pull/10310#discussion_r1622283026
##########
inlong-manager/manager-plugins/pom.xml:
##########
@@ -56,6 +53,9 @@
</profile>
<profile>
<id>v1.15</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
Review Comment:
This modification breaks the management of the InLong manager.
For now, users only need to change the `flink.version` in `flink-sort-plugin.propertie` if want to change the version of Flink.
But with this modification, users need to rebuild the plugin modules and replace the `manager-plugins-flink-xx.jar`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "wallezhang (via GitHub)" <gi...@apache.org>.
wallezhang commented on code in PR #10310:
URL: https://github.com/apache/inlong/pull/10310#discussion_r1625452320
##########
inlong-manager/manager-plugins/pom.xml:
##########
@@ -56,6 +53,9 @@
</profile>
<profile>
<id>v1.15</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
Review Comment:
Yes, this modification does have an impact on management of the InLong manager.
I will review it again. But from the current situation, many modules in `sort-flink-v1.13` depend on `sort-format-json-v1.13` module which will be excluded by v1.15 profile activation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on PR #10310:
URL: https://github.com/apache/inlong/pull/10310#issuecomment-2141316988
https://github.com/apache/inlong/blob/ca0983fcebf70c68f8e79f341c992b1d2c5970f4/inlong-manager/manager-plugins/base/src/main/resources/flink-sort-plugin.properties#L25 flink version in configuration also need to upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "wallezhang (via GitHub)" <gi...@apache.org>.
wallezhang commented on code in PR #10310:
URL: https://github.com/apache/inlong/pull/10310#discussion_r1621912678
##########
inlong-manager/manager-plugins/pom.xml:
##########
@@ -56,6 +53,9 @@
</profile>
<profile>
<id>v1.15</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
Review Comment:
There is a problem here. If I activate all versions, it will depend on the `sort-flink-dependencies-v1.13` module, which I have excluded because it is in the `sort-flink-v1.13` module. It also depends on `sort-format-json-v1.13`, but this module is excluded because the default activated profile has changed to v1.15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #10310:
URL: https://github.com/apache/inlong/pull/10310#discussion_r1621802941
##########
inlong-manager/manager-plugins/pom.xml:
##########
@@ -56,6 +53,9 @@
</profile>
<profile>
<id>v1.15</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
Review Comment:
building plugin for all Flink versions is fine here, so, there is no need to make the 1.15 profile active by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #10310:
URL: https://github.com/apache/inlong/pull/10310#discussion_r1630703575
##########
inlong-sort/sort-formats/format-row/pom.xml:
##########
@@ -52,10 +52,18 @@
<profiles>
<profile>
- <id>v1.13</id>
+ <id>all-flink-version</id>
Review Comment:
```suggestion
<id>flink-all-version</id>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10284][Manager][Sort] Upgrade flink default version to 1.15 [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #10310:
URL: https://github.com/apache/inlong/pull/10310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org