You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/12 11:07:57 UTC

[GitHub] [rocketmq-clients] guyinyou opened a new pull request, #151: golang

guyinyou opened a new pull request, #151:
URL: https://github.com/apache/rocketmq-clients/pull/151

   TODO:
   code style
   unit test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-clients] duhenglucky closed pull request #151: golang

Posted by GitBox <gi...@apache.org>.
duhenglucky closed pull request #151: golang
URL: https://github.com/apache/rocketmq-clients/pull/151


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-clients] zhouxinyu commented on a diff in pull request #151: golang

Posted by GitBox <gi...@apache.org>.
zhouxinyu commented on code in PR #151:
URL: https://github.com/apache/rocketmq-clients/pull/151#discussion_r950013327


##########
golang/example/producer/fifo/main.go:
##########
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package main
+
+import (
+	"context"
+	"fmt"
+	"log"
+	"os"
+	"strconv"
+	"time"
+
+	"github.com/apache/rocketmq-clients/golang"
+	"github.com/apache/rocketmq-clients/golang/credentials"
+)
+
+const (
+	// Topic         = "xxxxxx"
+	// ConsumerGroup = "xxxxxx"
+	// Endpoint      = "xxxxxx"
+	// Region        = "xxxxxx"
+	// AccessKey     = "xxxxxx"
+	// SecretKey     = "xxxxxx"
+
+	Topic         = "v2_grpc_fifo"
+	ConsumerGroup = "v2_grpc"
+	Endpoint      = "rmq-cn-tl32tb4s50g.cn-hangzhou.rmq.aliyuncs.com:8080"
+	Region        = "cn-zhangjiakou"
+	AccessKey     = "hM71WHX8Sx0OfGXR"

Review Comment:
   The instance has been leaked, please release the instance and avoid hard coding the ak/sk.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org